Send graceful shutdown signals to daemons in Phabricator
ClosedPublic
Actions

Authored by epriestley on Aug 12 2014, 2:34 AM.

Details

Reviewers

hach-que
btrahan

Maniphest Tasks

T5855: Implement a "graceful shutdown" mode for daemons

Commits

Restricted Diffusion Commit
rP9309723ac477: Send graceful shutdown signals to daemons in Phabricator

Summary

Fixes T5855. Adds a --graceful N flag to phd stop and phd restart.

phd will send SIGINT, wait N seconds, SIGTERM, wait 15 seconds, and SIGKILL. By default, N is 15.

Test Plan

Ran bin/phd debug ... and used ^C to interrupt daemons. Saw graceful shutdown behavior, and abrupt termination on multiple ^C.
Ran bin/phd start, bin/phd stop and bin/phd restart with --graceful set to various things, notably 0. Saw graceful shutdowns on the CLI and in the web UI. With 0, abrupt shutdowns.

Diff Detail

Repository

rP Phabricator

Branch

grace1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2163
Build 2167: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24613.Aug 12 2014, 2:34 AM

epriestley retitled this revision from to Send graceful shutdown signals to daemons in Phabricator.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: hach-que, btrahan.

epriestley added a task: T5855: Implement a "graceful shutdown" mode for daemons.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 12 2014, 2:34 AM

Harbormaster completed remote builds in B2163: Diff 24613.Aug 12 2014, 2:35 AM

Tried this out with --graceful 120. Is it intended that in the taskmaster log you'll see:

(2) Graceful shutdown in response to signal 2 (SIGINT).

but bin/phd restart will still be waiting for the daemon to exit? It seems like the process should quit after this and show "Daemon 1234 exited." as they exit.

In addition, the daemon showed a status of "Running" in the daemons app (the same one that reported the graceful shutdown).

In addition, it was only after the daemon got:

(15) Shutting down in response to signal 15 (SIGTERM).

that it moved to the status of "Exiting" in the daemons app.

(And it's still sitting at "Exiting" even though the process no longer exists)

Hrrm -- that's not expected, and not the behavior on my system.

If you bin/phd debug garbage and then ^C it, what happens?

Strangely enough, it has the expected behaviour when running a separate daemon as bin/phd debug, but not for any of the daemons started with bin/phd start or bin/phd restart.