Rename Lisk internal getProperties() methods to avoid collisions
ClosedPublic
Actions

Authored by epriestley on Aug 11 2014, 12:31 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP448020a57351: Rename Lisk internal getProperties() methods to avoid collisions

Summary

See some discussion here:

https://github.com/phacility/phabricator/commit/24a6eeb8d8a52b592e456d110934670d4ace9b31#commitcomment-7334892

The protected $properties; storage parameter added to ProjectColumn is shadowed by getProperties() in the base class.

Although this works correctly for me, it's ambiguous and worth fixing. Make the base class methods explicit.

Test Plan

Used grep to find callers for both methods and renamed them.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24572.Aug 11 2014, 12:31 PM

epriestley retitled this revision from to Rename Lisk internal getProperties() methods to avoid collisions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 11 2014, 12:31 PM

Harbormaster completed remote builds in B2142: Diff 24572.Aug 11 2014, 12:32 PM

btrahan accepted this revision.Aug 11 2014, 6:27 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 11 2014, 6:27 PM

Closed by commit rP448020a57351 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

storage/

lisk/

LiskDAO.php

12 lines

Diff 24596

View Options

src/infrastructure/storage/lisk/LiskDAO.php

Rename Lisk internal getProperties() methods to avoid collisionsClosedPublicActions