Fix Legalpad for logged-out users
ClosedPublic
Actions

Authored by epriestley on Aug 8 2014, 4:51 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T5739: "Visible To: Public" not working in Legalpad

Commits

Restricted Diffusion Commit
rPa1477baa3929: Fix Legalpad for logged-out users

Summary

Fixes T5739. I only got D9857 half right: the new method names are correct, but the bodies needed to change too.

Test Plan

Signed a document as an anonymous user.

Diff Detail

Repository

rP Phabricator

Branch

legal1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2107
Build 2111: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24518.Aug 8 2014, 4:51 PM

epriestley retitled this revision from to Fix Legalpad for logged-out users.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a task: T5739: "Visible To: Public" not working in Legalpad.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 8 2014, 4:51 PM

chad accepted this revision.Aug 8 2014, 4:52 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 8 2014, 4:52 PM

Harbormaster completed remote builds in B2107: Diff 24518.Aug 8 2014, 4:52 PM

Closed by commit rPa1477baa3929 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

legalpad/

controller/

LegalpadDocumentDoneController.php

2 lines

LegalpadDocumentSignController.php

2 lines

Diff 24518

View Options

src/applications/legalpad/controller/LegalpadDocumentDoneController.php