Page MenuHomePhabricator

When dragging stuff around, compensate for changes in scroll position
ClosedPublic

Authored by epriestley on Aug 7 2014, 11:41 PM.
Tags
None
Referenced Files
F10895251: D10186.diff
Mon, Jul 4, 3:19 PM
F10893961: D10186.diff
Mon, Jul 4, 5:16 AM
Unknown Object (File)
Mon, Jun 13, 8:15 AM
Unknown Object (File)
Tue, Jun 7, 9:41 AM
Unknown Object (File)
May 27 2022, 3:04 AM
Unknown Object (File)
May 27 2022, 3:03 AM
Unknown Object (File)
May 27 2022, 3:03 AM
Unknown Object (File)
May 27 2022, 3:02 AM
Subscribers

Details

Summary

Ref T5240. This fixes dragging stuff and using the mousewheel or keyboard to scroll the window during the drag.

(It does not fix "dragging near the edge of the container should scroll it" yet.)

Test Plan

Dragged stuff around on task list and workboards in Safari, Firefox and Chrome. Used mousewheel and shift + mousewheel to scroll the document and containers during drag. Object remained under the cursor.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to When dragging stuff around, compensate for changes in scroll position.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
webroot/rsrc/externals/javelin/lib/Vector.js
312

Nice. This scroll stuff is a pain in the butt and this will help a ton.

This revision is now accepted and ready to land.Aug 8 2014, 10:35 PM
epriestley updated this revision to Diff 24558.

Closed by commit rP0e98e33b3342 (authored by @epriestley).