Fix Phrequent duration accounting
ClosedPublic
Actions

Authored by epriestley on Aug 7 2014, 10:51 PM.

Tags

None

Referenced Files

	F15504248: D10184.id24499.diff
	Mon, Apr 14, 4:59 PM

	F15495898: D10184.id.diff
	Sun, Apr 13, 5:47 AM

	F15495808: D10184.id24506.diff
	Sun, Apr 13, 5:38 AM

	F15492142: D10184.diff
	Sat, Apr 12, 11:34 AM

	F15480902: D10184.id24499.diff
	Tue, Apr 8, 5:13 PM

	F15472386: D10184.id24499.diff
	Sat, Apr 5, 12:55 PM

	F15472368: D10184.id24506.diff
	Sat, Apr 5, 12:51 PM

	F15455778: D10184.diff
	Sun, Mar 30, 4:47 AM

View All Files

Subscribers

epriestley

Details

Reviewers

hach-que
btrahan

Maniphest Tasks

T5705: "Time spent" in Phrequent is incorrect

Commits

Restricted Diffusion Commit
rPc0585b7a34ed: Fix Phrequent duration accounting

Summary

Fixes T5705. This was just derp; instead of returning the duration of the first slice, return the duration of all the slices.

Test Plan

Added unit tests. Saw reasonable results in the UI.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24499.Aug 7 2014, 10:51 PM

epriestley retitled this revision from to Fix Phrequent duration accounting.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: hach-que, btrahan.

epriestley added a task: T5705: "Time spent" in Phrequent is incorrect.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 7 2014, 10:51 PM

Harbormaster completed remote builds in B2095: Diff 24499.Aug 7 2014, 10:52 PM

Quite derp indeed.

I'm going to go ahead and assume that this doesn't impact (or also fixes issues we didn't notice) with the Arcanist commands.

This revision is now accepted and ready to land.Aug 8 2014, 12:00 AM

Closed by commit rPc0585b7a34ed (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

phrequent/

storage/

PhrequentTimeSlices.php

6 lines

__tests__/

PhrequentTimeBlockTestCase.php

24 lines

Diff 24506

View Options

src/applications/phrequent/storage/PhrequentTimeSlices.php

View Options

src/applications/phrequent/storage/tests/PhrequentTimeBlockTestCase.php

Fix Phrequent duration accountingClosedPublicActions