Page MenuHomePhabricator

Support natural ordering of workboards
ClosedPublic

Authored by epriestley on Aug 7 2014, 8:52 PM.
Tags
None
Referenced Files
F14407660: D10182.id24515.diff
Tue, Dec 24, 3:24 AM
Unknown Object (File)
Fri, Dec 20, 6:29 AM
Unknown Object (File)
Fri, Dec 20, 4:26 AM
Unknown Object (File)
Wed, Dec 18, 10:56 AM
Unknown Object (File)
Thu, Dec 12, 11:33 AM
Unknown Object (File)
Sun, Dec 8, 11:12 PM
Unknown Object (File)
Fri, Dec 6, 6:18 PM
Unknown Object (File)
Wed, Dec 4, 5:11 AM
Subscribers

Details

Summary

Ref T4807. This is probably a complete fix, but I'd be surprised if there isn't a little cleanup I missed.

When users drag tasks on a "natural"-ordered workboard, leave things where they put them.

This isn't too bad since a lot of the existing work is completely reusable (e.g., we don't need any new JS).

Test Plan
  • Dragged a bunch of stuff around, it stayed where I put it after dropped and when reloaded.
  • Dragged stuff across priorities, no zany priority changes (in "natural" mode).
  • Created new tasks, they show up at the top.
  • Tagged new tasks, they show up at the top of backlog.
  • Swapped to "priority" mode and got sorting and the old priority-altering reordering.
  • Added tasks in priority mode.
  • Viewed task transactions for correctness/sanity.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Support natural ordering of workboards.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Clearer TODO comment: both JS and PHP do the same thing, they just take slightly different paths to get there.
chad added a reviewer: chad.
chad added a subscriber: chad.

(^^^)

This revision is now accepted and ready to land.Aug 8 2014, 3:05 PM
epriestley updated this revision to Diff 24515.

Closed by commit rP59a85e8845ef (authored by @epriestley).