Page MenuHomePhabricator
Differential D10172

Change "Stop" to "Pause" in Harbormaster build UI
ClosedPublic
Actions

Authored by hach-que on Aug 7 2014, 5:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 8:27 PM
Unknown Object (File)
Sun, Jan 26, 3:12 PM
Unknown Object (File)
Sat, Jan 25, 6:09 PM
Unknown Object (File)
Fri, Jan 24, 11:39 AM
Unknown Object (File)
Fri, Jan 24, 11:39 AM
Unknown Object (File)
Fri, Jan 24, 11:39 AM
Unknown Object (File)
Fri, Jan 24, 11:27 AM
Unknown Object (File)
Fri, Jan 24, 5:23 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T1049: Implement Harbormaster
T5814: "Stop Build" is confusing because it actually pauses the build
Commits
Restricted Diffusion Commit
rPbc116d7e02b4: Change "Stop" to "Pause" in Harbormaster build UI
Summary

Resolves T5814. Ref T1049. This changes "Stop" to "Pause" in the UI (internally it's still referred to as Stop).

Test Plan

Viewed builds and saw the intended wording.

Diff Detail

Repository
rP Phabricator
Branch
pause-build
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2077
Build 2079: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 24473.Aug 7 2014, 5:15 AM
hach-que retitled this revision from to Change "Stop" to "Pause" in UI.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
hach-que added a task: T5814: "Stop Build" is confusing because it actually pauses the build.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 7 2014, 5:15 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
hach-que retitled this revision from Change "Stop" to "Pause" in UI to Change "Stop" to "Pause" in Harbormaster build UI.Aug 7 2014, 5:15 AM
hach-que edited edge metadata.
Harbormaster completed remote builds in B2077: Diff 24473.Aug 7 2014, 5:16 AM
hach-que updated this object.Aug 7 2014, 7:29 AM
hach-que added a task: T1049: Implement Harbormaster.
epriestley accepted this revision.Aug 7 2014, 4:29 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 7 2014, 4:29 PM
hach-que closed this revision.Aug 7 2014, 10:25 PM
hach-que updated this revision to Diff 24495.

Closed by commit rPbc116d7e02b4 (authored by @hach-que).

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
controller/
20 lines
38 lines
53 lines
storage/
build/
2 lines

Diff 24473

View Options

src/applications/harbormaster/controller/HarbormasterBuildActionController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Loading...
Phabricator · Built by Phacility