Page MenuHomePhabricator
Differential D10140

Allow "arc browse" to browse objects
ClosedPublic
Actions

Authored by epriestley on Aug 4 2014, 5:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 12:32 AM
Unknown Object (File)
Sun, Dec 8, 6:53 AM
Unknown Object (File)
Fri, Dec 6, 11:36 PM
Unknown Object (File)
Fri, Dec 6, 2:53 PM
Unknown Object (File)
Mon, Dec 2, 1:56 PM
Unknown Object (File)
Mon, Dec 2, 1:56 PM
Unknown Object (File)
Mon, Dec 2, 1:56 PM
Unknown Object (File)
Mon, Dec 2, 1:53 PM
View All Files
Subscribers
epriestley
sophiebits

Details

Reviewers
btrahan
csilvers
Maniphest Tasks
T5781: Moar functionality for `arc browse`!
Commits
rARC2e6d11c18a97: Allow "arc browse" to browse objects
Summary

Ref T5781. This implements arc browse T234, for any monogrammed object.

Test Plan
  • Ran arc browse T234 outside of a working copy (does not require repository API).
  • Ran arc browse T234 in a working copy, got task.
  • Ran arc browse PATH in a working copy.
  • Ran arc browse nonpath with and without --force.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24387.Aug 4 2014, 5:26 PM
epriestley retitled this revision from to Allow "arc browse" to browse objects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, csilvers.
epriestley added a task: T5781: Moar functionality for `arc browse`!.
Herald added subscribers: sophiebits, epriestley. · View Herald TranscriptAug 4 2014, 5:26 PM
Harbormaster completed remote builds in B2030: Diff 24387.Aug 4 2014, 5:27 PM
csilvers edited edge metadata.Aug 4 2014, 5:41 PM

sweet!

epriestley updated this revision to Diff 24393.Aug 4 2014, 6:51 PM
epriestley edited edge metadata.
  • Simplify logic around $paths.
Harbormaster completed remote builds in B2034: Diff 24393.Aug 4 2014, 6:52 PM
btrahan accepted this revision.Aug 4 2014, 6:55 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 4 2014, 6:55 PM
epriestley closed this revision.Aug 4 2014, 7:02 PM
epriestley updated this revision to Diff 24395.

Closed by commit rARC2e6d11c18a97 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
workflow/
117 lines

Diff 24395

View Options

src/workflow/ArcanistBrowseWorkflow.php

Loading...
Phabricator · Built by Phacility