Page MenuHomePhabricator

Recognize Maniphest task description as a remarkup block
ClosedPublic

Authored by epriestley on Aug 4 2014, 4:21 PM.
Tags
None
Referenced Files
F14066213: D10139.diff
Tue, Nov 19, 8:47 AM
F14059110: D10139.id24386.diff
Sun, Nov 17, 5:33 PM
F14050674: D10139.diff
Thu, Nov 14, 8:02 PM
F14038372: D10139.diff
Sun, Nov 10, 11:13 PM
F14023221: D10139.diff
Thu, Nov 7, 12:07 AM
F14006350: D10139.diff
Mon, Oct 28, 7:06 AM
F14004714: D10139.id.diff
Sun, Oct 27, 1:37 AM
Unknown Object (File)
Oct 1 2024, 5:56 PM
Subscribers

Details

Summary

Ref T4589. We don't recognize task descriptions as remarkup blocks, so {F...} references in them do not get attached to the objects, and thus no policy exemption is created.

Recognize them, which activates {F...} and @mentions.

We probably have a few more of these in other applications, but it's not a big deal to clean them up as they arise.

Test Plan

Uploaded a file to a task in the description field, saw it attach and get a policy exemption.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Recognize Maniphest task description as a remarkup block.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 4 2014, 6:52 PM
epriestley updated this revision to Diff 24399.

Closed by commit rP86dbf1d17d20 (authored by @epriestley).