Page MenuHomePhabricator

Recognize Maniphest task description as a remarkup block
ClosedPublic

Authored by epriestley on Aug 4 2014, 4:21 PM.
Tags
None
Referenced Files
F18732283: D10139.diff
Tue, Sep 30, 5:24 PM
F18650732: D10139.id24386.diff
Sun, Sep 21, 1:33 AM
F18459988: D10139.id24386.diff
Sep 1 2025, 6:27 PM
F18459098: D10139.id24399.diff
Sep 1 2025, 4:15 PM
F18399876: D10139.diff
Aug 29 2025, 5:08 PM
F18102515: D10139.id24399.diff
Aug 9 2025, 9:24 PM
F18047812: D10139.id.diff
Aug 3 2025, 1:09 PM
F18018571: D10139.id24386.diff
Aug 2 2025, 7:04 PM
Subscribers

Details

Summary

Ref T4589. We don't recognize task descriptions as remarkup blocks, so {F...} references in them do not get attached to the objects, and thus no policy exemption is created.

Recognize them, which activates {F...} and @mentions.

We probably have a few more of these in other applications, but it's not a big deal to clean them up as they arise.

Test Plan

Uploaded a file to a task in the description field, saw it attach and get a policy exemption.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Recognize Maniphest task description as a remarkup block.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 4 2014, 6:52 PM
epriestley updated this revision to Diff 24399.

Closed by commit rP86dbf1d17d20 (authored by @epriestley).