Page MenuHomePhabricator

Invalidate outstanding password reset links when users adjust email addresses
ClosedPublic

Authored by epriestley on Aug 3 2014, 6:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 10:41 PM
Unknown Object (File)
Thu, Apr 11, 12:12 AM
Unknown Object (File)
Wed, Apr 10, 12:10 AM
Unknown Object (File)
Mar 24 2024, 1:04 AM
Unknown Object (File)
Mar 24 2024, 12:45 AM
Unknown Object (File)
Mar 23 2024, 12:39 PM
Unknown Object (File)
Feb 16 2024, 1:32 PM
Unknown Object (File)
Feb 7 2024, 11:46 PM
Subscribers

Details

Summary

Fixes T5506. Depends on D10133. When users remove an email address or change their primary email address, invalidate any outstanding password reset links.

This is a very small security risk, but the current behavior is somewhat surprising, and an attacker could sit on a reset link for up to 24 hours and then use it to re-compromise an account.

Test Plan
  • Changed primary address and removed addreses.
  • Verified these actions invalidated outstanding one-time login temporary tokens.
  • Tried to use revoked reset links.
  • Revoked normally from new UI panel.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Invalidate outstanding password reset links when users adjust email addresses.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 4 2014, 6:51 PM
epriestley updated this revision to Diff 24403.

Closed by commit rPe56dc8f29986 (authored by @epriestley).