Page MenuHomePhabricator

Apply normal Audit actions directly with Transaction editor
ClosedPublic

Authored by epriestley on Aug 2 2014, 7:29 PM.
Tags
None
Referenced Files
F18372823: D10128.diff
Thu, Aug 28, 6:51 AM
F18047799: D10128.id.diff
Sun, Aug 3, 1:09 PM
F18036678: D10128.id24355.diff
Sun, Aug 3, 2:16 AM
F17895344: D10128.id.diff
Jul 29 2025, 6:12 AM
F17894253: D10128.id24365.diff
Jul 29 2025, 5:37 AM
F17884639: D10128.id24365.diff
Jul 29 2025, 12:03 AM
F17868541: D10128.diff
Jul 28 2025, 7:54 AM
F17843381: D10128.id24355.diff
Jul 27 2025, 12:51 AM
Subscribers

Details

Summary

Ref T4896. This converts the last "CommentEditor" to a transaction editor and removes a large part of the old code.

Test Plan
  • Added comments.
  • Accepted / added auditors.
  • Added inline comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Apply normal Audit actions directly with Transaction editor.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
btrahan edited edge metadata.

awesometown

src/applications/audit/controller/PhabricatorAuditAddCommentController.php
86–88

surprised this logic isn't a method on commit or something.

This revision is now accepted and ready to land.Aug 2 2014, 9:09 PM
epriestley updated this revision to Diff 24365.

Closed by commit rPb5750412c75b (authored by @epriestley).