Page MenuHomePhabricator

Application Search - fix error updating searches from human-readable links
ClosedPublic

Authored by btrahan on Aug 2 2014, 12:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 12:38 PM
Unknown Object (File)
Thu, Mar 14, 2:03 AM
Unknown Object (File)
Feb 9 2024, 3:38 PM
Unknown Object (File)
Feb 3 2024, 12:19 AM
Unknown Object (File)
Jan 31 2024, 5:27 PM
Unknown Object (File)
Jan 31 2024, 5:27 PM
Unknown Object (File)
Jan 31 2024, 5:27 PM
Unknown Object (File)
Jan 29 2024, 2:17 PM
Subscribers

Details

Summary

Fixes T5666. When we have a pretty link right now it can conflict with form data; e.g. if you have 'statuses=open' in the URI and then uncheck status = open in the UI, you will still get the open status in the next search.

To fix this, set the form action explicitly to lose all the get parameter junk.

Test Plan

tried the test case in T5666 / this description and it no longer failed...!

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Application Search - fix error updating searches from human-readable links.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Possible alternative inline, not sure if that works but maybe it's clear if it does?

src/applications/search/controller/PhabricatorApplicationSearchController.php
155–157

Would ->setAction($request->getPath()) here also work, without losing the URI / costing a redirect?

This revision is now accepted and ready to land.Aug 2 2014, 12:16 AM
btrahan edited edge metadata.

Do it the way better setAction way.

btrahan updated this revision to Diff 24325.

Closed by commit rPdd918b0d1481 (authored by @btrahan).