Page MenuHomePhabricator
Differential D10115

Application Search - fix error updating searches from human-readable links
ClosedPublic
Actions

Authored by btrahan on Aug 2 2014, 12:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 7, 10:07 PM
Unknown Object (File)
Fri, Feb 7, 10:07 PM
Unknown Object (File)
Fri, Feb 7, 10:07 PM
Unknown Object (File)
Fri, Feb 7, 10:07 PM
Unknown Object (File)
Fri, Feb 7, 10:07 PM
Unknown Object (File)
Jan 27 2025, 1:07 PM
Unknown Object (File)
Jan 25 2025, 10:25 PM
Unknown Object (File)
Jan 24 2025, 4:16 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T5666: Searching tasks in a project, unchecking "open" takes two submits to switch.
Commits
Restricted Diffusion Commit
rPdd918b0d1481: Application Search - fix error updating searches from human-readable links
Summary

Fixes T5666. When we have a pretty link right now it can conflict with form data; e.g. if you have 'statuses=open' in the URI and then uncheck status = open in the UI, you will still get the open status in the next search.

To fix this, set the form action explicitly to lose all the get parameter junk.

Test Plan

tried the test case in T5666 / this description and it no longer failed...!

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan updated this revision to Diff 24323.Aug 2 2014, 12:10 AM
btrahan added a task: T5666: Searching tasks in a project, unchecking "open" takes two submits to switch. .
btrahan retitled this revision from to Application Search - fix error updating searches from human-readable links.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 2 2014, 12:10 AM
Harbormaster completed remote builds in B1992: Diff 24323.Aug 2 2014, 12:12 AM
btrahan updated this object.Aug 2 2014, 12:12 AM
epriestley accepted this revision.Aug 2 2014, 12:16 AM
epriestley edited edge metadata.

Possible alternative inline, not sure if that works but maybe it's clear if it does?

src/applications/search/controller/PhabricatorApplicationSearchController.php
155–157

Would ->setAction($request->getPath()) here also work, without losing the URI / costing a redirect?

This revision is now accepted and ready to land.Aug 2 2014, 12:16 AM
btrahan updated this revision to Diff 24324.Aug 2 2014, 12:18 AM
btrahan edited edge metadata.

Do it the way better setAction way.

btrahan updated this object.Aug 2 2014, 12:19 AM
btrahan closed this revision.Aug 2 2014, 12:19 AM
btrahan updated this revision to Diff 24325.

Closed by commit rPdd918b0d1481 (authored by @btrahan).

Harbormaster completed remote builds in B1993: Diff 24324.Aug 2 2014, 12:19 AM

Revision Contents
Changeset List

PathSize
src/
applications/
search/
controller/
3 lines

Diff 24325

View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
Phabricator · Built by Phacility