Page MenuHomePhabricator

Use standard infrastructure for Feed in Audit
ClosedPublic

Authored by epriestley on Aug 1 2014, 8:34 PM.
Tags
None
Referenced Files
F18221038: D10114.diff
Tue, Aug 19, 5:17 PM
F18096429: D10114.diff
Fri, Aug 8, 6:53 AM
F18084562: D10114.id24336.diff
Tue, Aug 5, 4:06 PM
F18047791: D10114.id.diff
Sun, Aug 3, 1:09 PM
F18045193: D10114.id24320.diff
Sun, Aug 3, 8:34 AM
F18007468: D10114.id24336.diff
Sat, Aug 2, 2:16 PM
F17998213: D10114.diff
Sat, Aug 2, 5:44 AM
F17853884: D10114.diff
Jul 27 2025, 2:28 PM
Subscribers

Details

Summary

Ref T4896. Instead of using custom stuff, use standard stuff.

Test Plan

Viewed a bunch of feed stories and published some over the Asana bridge.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Use standard infrastructure for Feed in Audit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/audit/storage/PhabricatorAuditTransaction.php
191–203

not for this diff but this sort of logic can probably go in the base Transaction class / some other central class?

This revision is now accepted and ready to land.Aug 1 2014, 8:40 PM

Yeah -- those transaction types are just going to migrate away at the end of this diff sequence.

epriestley updated this revision to Diff 24336.

Closed by commit rP49bd5721c5a7 (authored by @epriestley).