Page MenuHomePhabricator
Differential D10114

Use standard infrastructure for Feed in Audit
ClosedPublic
Actions

Authored by epriestley on Aug 1 2014, 8:34 PM.
Tags
None
Referenced Files
F13049239: D10114.id24336.diff
Fri, Apr 19, 2:05 AM
F13049238: D10114.id24320.diff
Fri, Apr 19, 2:05 AM
F13049237: D10114.id.diff
Fri, Apr 19, 2:05 AM
Unknown Object (File)
Sun, Apr 14, 4:47 PM
Unknown Object (File)
Thu, Apr 11, 8:52 AM
Unknown Object (File)
Thu, Apr 11, 3:27 AM
Unknown Object (File)
Thu, Mar 21, 11:42 AM
Unknown Object (File)
Feb 2 2024, 10:53 AM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
Maniphest Tasks
T4896: Move Audit to ApplicationTransactions
Commits
Restricted Diffusion Commit
rP49bd5721c5a7: Use standard infrastructure for Feed in Audit
Summary

Ref T4896. Instead of using custom stuff, use standard stuff.

Test Plan

Viewed a bunch of feed stories and published some over the Asana bridge.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24320.Aug 1 2014, 8:34 PM
epriestley retitled this revision from to Use standard infrastructure for Feed in Audit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
epriestley added a task: T4896: Move Audit to ApplicationTransactions.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 1 2014, 8:34 PM
Harbormaster completed remote builds in B1990: Diff 24320.Aug 1 2014, 8:35 PM
btrahan accepted this revision.Aug 1 2014, 8:40 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/audit/storage/PhabricatorAuditTransaction.php
191–203

not for this diff but this sort of logic can probably go in the base Transaction class / some other central class?

This revision is now accepted and ready to land.Aug 1 2014, 8:40 PM
epriestley added a comment.Aug 1 2014, 8:41 PM

Yeah -- those transaction types are just going to migrate away at the end of this diff sequence.

Harbormaster completed remote builds in B1990: Diff 24320.Aug 1 2014, 10:05 PM
epriestley closed this revision.Aug 2 2014, 7:07 AM
epriestley updated this revision to Diff 24336.

Closed by commit rP49bd5721c5a7 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
49 lines
6 lines
storage/
87 lines
auth/
controller/
2 lines
diffusion/
doorkeeper/
28 lines
transactions/
feed/
2 lines

Diff 24336

View Options

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

Loading...
View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditTransaction.php

Loading...
View Options

src/applications/auth/controller/PhabricatorAuthLoginController.php

Loading...
View Options

src/applications/diffusion/doorkeeper/DiffusionDoorkeeperCommitFeedStoryPublisher.php

Loading...
View Options

src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php

Loading...
Phabricator · Built by Phacility