Ref T4896. Currently, subscriptions to commits are stored as auditors with a special "CC" type.
Instead, use normal subscriptions storage, reads and writes.
Differential D10103
Move Audit to proper Subscriptions epriestley on Aug 1 2014, 1:08 AM. Authored by Tags None Referenced Files
Subscribers Tokens
Details
Ref T4896. Currently, subscriptions to commits are stored as auditors with a special "CC" type. Instead, use normal subscriptions storage, reads and writes.
Diff Detail
Event TimelineComment Actions
Comment Actions The subscriptions issue is kind of tricky, we have some similar problems elsewhere. The easiest example is:
So it:
This means that isAutomaticallySubscribed() can't rely on any data which isn't loaded by ObjectQuery. Examples of data like this are project members, Differential reviewers, and auditors. Some options I can see:
I don't really love any of these and it's not a huge issue to get it wrong (users can just appear in both "Subscribers" and "Reviewers/Auditors") so I'm just kind of ignoring it for now and hoping the answer becomes obvious in the future.
|