Page MenuHomePhabricator

Maybe fix excluding to / cc folks on differential emails

Authored by btrahan on Jul 30 2014, 11:06 PM.
Referenced Files
F13342272: D10087.diff
Thu, Jun 20, 11:30 AM
F13337157: D10087.id24255.diff
Wed, Jun 19, 9:14 AM
F13337155: D10087.id24263.diff
Wed, Jun 19, 9:14 AM
F13288421: D10087.diff
Tue, Jun 4, 10:26 AM
F13253109: D10087.diff
Sat, May 25, 2:24 AM
F13230868: D10087.diff
May 20 2024, 11:22 PM
F13210602: D10087.diff
May 17 2024, 5:02 AM
F13194576: D10087.diff
May 12 2024, 9:40 PM



Ref T5185. By code inspection, I am pretty sure before this patch it was doing a set of a get on itself which does nothing. Now, being careful not to break Facebook we get the proper exclusion phids. I am pretty sure the folks in T5185 are experiencing this in Differential only.

Test Plan

Get some folks on T5185 to play with this

Diff Detail

rP Phabricator
Lint Errors
Errorsrc/applications/phragment/controller/PhragmentZIPController.php:54PHL1Unknown Symbol
Errorsrc/applications/phragment/controller/PhragmentZIPController.php:70PHL1Unknown Symbol
Errorsrc/applications/phragment/storage/PhragmentFragment.php:143PHL1Unknown Symbol
Tests Passed
Build Status
Buildable 1947
Build 1948: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Maybe fix excluding to / cc folks on differential emails.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 30 2014, 11:14 PM
btrahan updated this revision to Diff 24263.

Closed by commit rPb2116a88636a (authored by @btrahan).