Differential D10087

Maybe fix excluding to / cc folks on differential emails
ClosedPublic
Actions

Authored by btrahan on Jul 30 2014, 11:06 PM.

Tags

None

Referenced Files

	F18724575: D10087.id24263.diff
	Sep 30 2025, 3:51 AM

	F18712030: D10087.id.diff
	Sep 29 2025, 5:15 AM

	F18671738: D10087.id24255.diff
	Sep 25 2025, 5:02 AM

	F18669971: D10087.diff
	Sep 24 2025, 10:37 PM

	F18661823: D10087.diff
	Sep 23 2025, 8:15 PM

	F18617585: D10087.id.diff
	Sep 14 2025, 9:35 PM

	F18440383: D10087.id24263.diff
	Aug 31 2025, 3:41 PM

	F18418696: D10087.id24255.diff
	Aug 30 2025, 1:37 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T5185: Comment emails generated from parsing incoming email replies should not go to people already on the To/CC of the incoming email

Commits

Restricted Diffusion Commit
rPb2116a88636a: Maybe fix excluding to / cc folks on differential emails

Summary

Ref T5185. By code inspection, I am pretty sure before this patch it was doing a set of a get on itself which does nothing. Now, being careful not to break Facebook we get the proper exclusion phids. I am pretty sure the folks in T5185 are experiencing this in Differential only.

Test Plan

Get some folks on T5185 to play with this

Diff Detail

Repository

Branch

master

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/applications/phragment/controller/PhragmentZIPController.php:54	PHL1	Unknown Symbol
Error	src/applications/phragment/controller/PhragmentZIPController.php:70	PHL1	Unknown Symbol
Error	src/applications/phragment/storage/PhragmentFragment.php:143	PHL1	Unknown Symbol

Unit

Tests Passed

Build Status

Buildable 1947
Build 1948: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 24255.Jul 30 2014, 11:06 PM

btrahan retitled this revision from to Maybe fix excluding to / cc folks on differential emails.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

btrahan added a task: T5185: Comment emails generated from parsing incoming email replies should not go to people already on the To/CC of the incoming email.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 30 2014, 11:06 PM

Harbormaster completed remote builds in B1947: Diff 24255.Jul 30 2014, 11:07 PM

epriestley accepted this revision.Jul 30 2014, 11:14 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 30 2014, 11:14 PM

Closed by commit rPb2116a88636a (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

mail/

DifferentialReplyHandler.php

14 lines

Diff 24255

src/applications/differential/mail/DifferentialReplyHandler.php

Loading...