Page MenuHomePhabricator

Maybe fix excluding to / cc folks on differential emails
ClosedPublic

Authored by btrahan on Jul 30 2014, 11:06 PM.
Tags
None
Referenced Files
F13230868: D10087.diff
Mon, May 20, 11:22 PM
F13210602: D10087.diff
Fri, May 17, 5:02 AM
F13194576: D10087.diff
Sun, May 12, 9:40 PM
F13177348: D10087.diff
Wed, May 8, 7:38 PM
F13176381: D10087.id24263.diff
Wed, May 8, 1:19 PM
Unknown Object (File)
Mon, Apr 29, 2:37 PM
Unknown Object (File)
Thu, Apr 25, 2:07 AM
Unknown Object (File)
Wed, Apr 24, 10:41 PM
Subscribers

Details

Summary

Ref T5185. By code inspection, I am pretty sure before this patch it was doing a set of a get on itself which does nothing. Now, being careful not to break Facebook we get the proper exclusion phids. I am pretty sure the folks in T5185 are experiencing this in Differential only.

Test Plan

Get some folks on T5185 to play with this

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Maybe fix excluding to / cc folks on differential emails.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 30 2014, 11:14 PM
btrahan updated this revision to Diff 24263.

Closed by commit rPb2116a88636a (authored by @btrahan).