Differential D10082

Make the 404 page device friendly.
ClosedPublic
Actions

Authored by btrahan on Jul 30 2014, 8:27 PM.

Tags

None

Referenced Files

	F15471316: D10082.id24244.diff
	Sat, Apr 5, 4:30 AM

	F15462416: D10082.id24243.diff
	Tue, Apr 1, 3:01 PM

	F15443316: D10082.id24244.diff
	Thu, Mar 27, 3:40 AM

	F15434115: D10082.id24243.diff
	Tue, Mar 25, 2:02 AM

	F15412374: D10082.id.diff
	Wed, Mar 19, 12:44 PM

	F15404907: D10082.id24243.diff
	Tue, Mar 18, 9:37 AM

	F15401252: D10082.id24243.diff
	Mon, Mar 17, 4:32 PM

	F15400783: D10082.id24243.diff
	Mon, Mar 17, 1:59 PM

Subscribers

Details

Reviewers

epriestley
chad

Maniphest Tasks

T5686: 404 page is not mobile-friendly

Commits

Restricted Diffusion Commit
rP7aaa6329b8a6: Make the 404 page device friendly.

Summary

Fixes T5686.

Test Plan

Viewed in iOS simulator and Chrome with various viewport sizes - looked good!

Diff Detail

Repository

Branch

T5686

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/applications/phragment/controller/PhragmentZIPController.php:54	PHL1	Unknown Symbol
Error	src/applications/phragment/controller/PhragmentZIPController.php:70	PHL1	Unknown Symbol
Error	src/applications/phragment/storage/PhragmentFragment.php:143	PHL1	Unknown Symbol

Unit

Tests Passed

Build Status

Buildable 1941
Build 1942: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 24243.Jul 30 2014, 8:27 PM

btrahan added a task: T5686: 404 page is not mobile-friendly.

btrahan retitled this revision from to Make the 404 page device friendly..

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added a reviewer: chad. · View Herald TranscriptJul 30 2014, 8:27 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jul 30 2014, 8:27 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 30 2014, 8:27 PM

Screen_Shot_2014-07-30_at_1.28.09_PM.png (902×1 px, 213 KB)

Screen_Shot_2014-07-30_at_1.28.07_PM.png (898×1 px, 268 KB)

Screen_Shot_2014-07-30_at_1.28.03_PM.png (916×1 px, 296 KB)

Screen_Shot_2014-07-30_at_1.27.47_PM.png (1×828 px, 350 KB)

Harbormaster completed remote builds in B1941: Diff 24243.Jul 30 2014, 8:28 PM

Closed by commit rP7aaa6329b8a6 (authored by @btrahan).

Celerity

Revision Contents
Changeset List

Path

Size

src/

aphront/

response/

Aphront404Response.php

15 lines

webroot/

rsrc/

css/

aphront/

request-failure-view.css

6 lines

Diff 24243

src/aphront/response/Aphront404Response.php

Loading...

webroot/rsrc/css/aphront/request-failure-view.css

Loading...