Make the 404 page device friendly.
ClosedPublic
Actions

Authored by btrahan on Jul 30 2014, 8:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 25, 5:04 PM

	Unknown Object (File)
	Fri, Jan 24, 10:12 AM

	Unknown Object (File)
	Thu, Jan 23, 9:59 PM

	Unknown Object (File)
	Sun, Jan 19, 6:25 AM

	Unknown Object (File)
	Fri, Jan 17, 7:42 PM

	Unknown Object (File)
	Dec 25 2024, 2:27 AM

	Unknown Object (File)
	Dec 19 2024, 7:59 PM

	Unknown Object (File)
	Dec 9 2024, 12:43 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley
chad

Maniphest Tasks

T5686: 404 page is not mobile-friendly

Commits

Restricted Diffusion Commit
rP7aaa6329b8a6: Make the 404 page device friendly.

Summary

Fixes T5686.

Test Plan

Viewed in iOS simulator and Chrome with various viewport sizes - looked good!

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 24243.Jul 30 2014, 8:27 PM

btrahan added a task: T5686: 404 page is not mobile-friendly.

btrahan retitled this revision from to Make the 404 page device friendly..

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added a reviewer: chad. · View Herald TranscriptJul 30 2014, 8:27 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

epriestley accepted this revision.Jul 30 2014, 8:27 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 30 2014, 8:27 PM

Screen_Shot_2014-07-30_at_1.28.09_PM.png (902×1 px, 213 KB)

Screen_Shot_2014-07-30_at_1.28.07_PM.png (898×1 px, 268 KB)

Screen_Shot_2014-07-30_at_1.28.03_PM.png (916×1 px, 296 KB)

Screen_Shot_2014-07-30_at_1.27.47_PM.png (1×828 px, 350 KB)

Harbormaster completed remote builds in B1941: Diff 24243.Jul 30 2014, 8:28 PM

Closed by commit rP7aaa6329b8a6 (authored by @btrahan).

Celerity

Revision Contents
Changeset List

Path

Size

src/

aphront/

response/

Aphront404Response.php

15 lines

webroot/

rsrc/

css/

aphront/

request-failure-view.css

6 lines

Diff 24244

View Options

src/aphront/response/Aphront404Response.php