Page MenuHomePhabricator

Workboards - fix adding new tasks and sorting
ClosedPublic

Authored by btrahan on Jul 30 2014, 8:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 8:20 AM
Unknown Object (File)
Sun, Dec 15, 4:48 PM
Unknown Object (File)
Thu, Dec 5, 12:22 AM
Unknown Object (File)
Tue, Dec 3, 9:42 PM
Unknown Object (File)
Nov 26 2024, 10:55 PM
Unknown Object (File)
Nov 22 2024, 8:27 PM
Unknown Object (File)
Nov 18 2024, 3:25 AM
Unknown Object (File)
Nov 15 2024, 12:08 AM
Subscribers

Details

Summary

At least on my install, sorting was pretty borked from a type issue. (e.g. "unbreak now" of 100 sorting as less than "High" of 90). Fix this with some parseInt action. Also support adding new cards with the new colsort stuff. The clever bit here is to include the task ID in the sorting vector because the task ID wins ties at the moment I think / new tasks need to show up before older tasks when they are initially created. Fixes T5716.

Test Plan

added many "normal" priority cards and saw them fly in correctly. changed priority and moved correctly. made no edits and no moves were made correctly.

Diff Detail

Repository
rP Phabricator
Branch
T5716
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/applications/phragment/controller/PhragmentZIPController.php:54PHL1Unknown Symbol
Errorsrc/applications/phragment/controller/PhragmentZIPController.php:70PHL1Unknown Symbol
Errorsrc/applications/phragment/storage/PhragmentFragment.php:143PHL1Unknown Symbol
Unit
No Test Coverage
Build Status
Buildable 1940
Build 1941: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Workboards - fix adding new tasks and sorting.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 30 2014, 8:05 PM
btrahan updated this revision to Diff 24242.

Closed by commit rP90431fd101b4 (authored by @btrahan).