Differential D10062

Prevent text selection (mostly) on workpanels
ClosedPublic
Actions

Authored by chad on Jul 28 2014, 4:30 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T5719: Prevent text selection inside tasks in workboard

Commits

Restricted Diffusion Commit
rP0c15ad5d5cd3: Prevent text selection (mostly) on workpanels

Summary

Fixes T5719, Not completely convinced we won't see another ticket here, but overall testing it feels better.

Test Plan

dragon drop a lot of stuff.

Diff Detail

Repository

rP Phabricator

Branch

text-select

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1912
Build 1913: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 24194.Jul 28 2014, 4:30 PM

chad retitled this revision from to Prevent text selection (mostly) on workpanels.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T5719: Prevent text selection inside tasks in workboard.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 28 2014, 4:30 PM

Screen_Shot_2014-07-28_at_9.26.15_AM.png (980×674 px, 89 KB)

Screen_Shot_2014-07-28_at_9.25.09_AM.png (978×666 px, 92 KB)

Harbormaster completed remote builds in B1912: Diff 24194.Jul 28 2014, 4:31 PM

Yeah, this feels like a good thing to try first. We can do a bunch of JS if it doesn't work, but I think there's a good chance this is sufficient, and it's way simpler.

This revision is now accepted and ready to land.Jul 28 2014, 4:37 PM

Closed by commit rP0c15ad5d5cd3 (authored by @chad).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

phui/

phui-workpanel-view.css

18 lines

Diff 24194

View Options

resources/celerity/map.php