Allow objects to be linked even if they are missing other fields
ClosedPublic
Actions

Authored by epriestley on Jul 26 2014, 12:03 PM.

Details

Reviewers

joshuaspence
btrahan
chad

Maniphest Tasks

Commits

Restricted Diffusion Commit
rPc75e12038c6d: Allow objects to be linked even if they are missing other fields

Summary

Fixes T5717. Like other partial edits, object links should not be blocked by unrelated missing fields on the object.

Test Plan

Linked two objects.
Verified the inverse editor already sets "continue on missing fields" and "continue on no effect".

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24185.Jul 26 2014, 12:03 PM

epriestley retitled this revision from to Allow objects to be linked even if they are missing other fields.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, chad, btrahan.

epriestley added a task: T5717: Unrelated validation exception when adding blocking task.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 26 2014, 12:03 PM

Harbormaster completed remote builds in B1906: Diff 24185.Jul 26 2014, 12:04 PM

joshuaspence accepted this revision.Jul 26 2014, 1:45 PM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.Jul 26 2014, 1:45 PM

Closed by commit rPc75e12038c6d (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

controller/

PhabricatorSearchAttachController.php

4 lines

Diff 24187

View Options

src/applications/search/controller/PhabricatorSearchAttachController.php

Allow objects to be linked even if they are missing other fieldsClosedPublicActions