Page MenuHomePhabricator
Differential D10044

Improve text mode rendering of reverse Remarkup list staircases
ClosedPublic
Actions

Authored by epriestley on Jul 24 2014, 11:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 2:45 PM
Unknown Object (File)
Sat, Dec 14, 12:50 PM
Unknown Object (File)
Fri, Dec 6, 12:39 PM
Unknown Object (File)
Nov 27 2024, 12:10 PM
Unknown Object (File)
Nov 18 2024, 11:42 PM
Unknown Object (File)
Nov 11 2024, 7:40 AM
Unknown Object (File)
Nov 11 2024, 6:36 AM
Unknown Object (File)
Nov 11 2024, 2:13 AM
View All Files
Subscribers
epriestley

Details

Reviewers
asherkin
btrahan
chad
Maniphest Tasks
T5102: Markdown syntax of README.md file present in a repository is not well rendered
Commits
rPHU371c33b73585: Improve text mode rendering of reverse Remarkup list staircases
Summary

Ref T5102. The text-only mode of these was a bit silly.

Test Plan

Added and executed unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
list2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1880
Build 1881: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24140.Jul 24 2014, 11:20 PM
epriestley retitled this revision from to Improve text mode rendering of reverse Remarkup list staircases.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: asherkin, chad, btrahan.
epriestley added a task: T5102: Markdown syntax of README.md file present in a repository is not well rendered.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 24 2014, 11:20 PM
Harbormaster completed remote builds in B1880: Diff 24140.Jul 24 2014, 11:21 PM
chad accepted this revision.Jul 25 2014, 4:06 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 25 2014, 4:06 AM
epriestley closed this revision.Jul 25 2014, 4:58 AM
epriestley updated this revision to Diff 24165.

Closed by commit rPHU371c33b73585 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
markup/
engine/
__tests__/
remarkup/
1 line
4 lines
remarkup/
blockrule/
79 lines

Diff 24140

View Options

src/markup/engine/__tests__/remarkup/list-crazystairs.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/list-staircase.txt

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupListBlockRule.php

Loading...
Phabricator · Built by Phacility