Page MenuHomePhabricator

Choose a better class name for PhutilMethodNotImplementedException
ClosedPublic

Authored by epriestley on Jul 23 2014, 3:17 PM.
Tags
None
Referenced Files
F15500113: D10030.diff
Sun, Apr 13, 4:11 PM
F15409763: D10030.id24105.diff
Mar 19 2025, 5:11 AM
F15409166: D10030.id24138.diff
Mar 19 2025, 3:30 AM
F15408219: D10030.id.diff
Mar 18 2025, 9:43 PM
F15401055: D10030.diff
Mar 17 2025, 3:27 PM
F15310109: D10030.id24138.diff
Mar 6 2025, 8:05 AM
Unknown Object (File)
Feb 20 2025, 1:39 PM
Unknown Object (File)
Feb 7 2025, 9:16 AM
Subscribers

Details

Summary

If you call $subclass->method() and the base class provides a default implementation which throws, you get BaseClass in the exception message.

Instead, produce Subclass in this case.

Test Plan

With Application subclasses missing getName() implementations, got more useful exceptions (e.g., "PhabricatorPasteApplication" is missing a method, not "PhabricatorApplication").

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Choose a better class name for PhutilMethodNotImplementedException.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
This revision is now accepted and ready to land.Jul 23 2014, 10:12 PM
epriestley updated this revision to Diff 24138.

Closed by commit rPHU4298b0da1573 (authored by @epriestley).