HomePhabricator

Conpherence - refine menu interactions with respect to "Show More"

Description

Conpherence - refine menu interactions with respect to "Show More"

Summary:
Ref T7566. Prior to this diff, we had a broken mess in the "Messages" section. Now, "Messages" behave like rooms in that whatever is loaded at page load time is at the top of the list.

Additionally, refine "show more" behavior such that it simply shows the next X, but if there exists X + 1 then we have another "show more" that kicks you to application search. Theoretically, there are still corner cases where users are in a ton of rooms or a ton of messages respectively, but this feels pretty good.

Consolidates title rendering code so we always render the list of participants and no more "No Title".

Also remove the policy icons for messages consistently, helping to differentiate them from rooms at a glance.

Test Plan: clicked around in conpherence main - looked good. tried "show more" and it worked! played around in durable column and things seemed reasonable there too.

Reviewers: chad, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7566

Differential Revision: https://secure.phabricator.com/D12222

Details

Provenance
btrahanAuthored on
btrahanPushed on Mar 31 2015, 7:45 PM
Reviewer
epriestley
Differential Revision
D12222: Conpherence - refine menu interactions with respect to "Show More"
Parents
rPfb58932eb8db: Less janky searching on mobile devices
Branches
Unknown
Tags
Unknown
Tasks
T7566: Implement "Rooms" in Conpherence