Fix paging fatal with flagged objects
3c4322252513
Actions

Description

Fix paging fatal with flagged objects

Summary: Fixes T13331. Just adds a generic withIDs() method to PhabricatorFlagQuery.

Test Plan: Flagged > 100 objects, observed fatal attempting to page. Next page loads as expected after fix.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T13331

Differential Revision: https://secure.phabricator.com/D20642

Details

Provenance

amckinley	Authored on Jul 4 2019, 11:00 PM
amckinley	Pushed on Jul 5 2019, 9:25 PM

Reviewer

epriestley

Differential Revision

D20642: Fix paging fatal with flagged objects

Parents

rP45f421154179: Fix URI escaping, which should actually be "%s", not "%p"

Branches

Unknown

Tags

Unknown

Tasks

T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()"

Build Status

Buildable 23113
Build 31734: Run Core Tests

Event Timeline

amckinley committed rP3c4322252513: Fix paging fatal with flagged objects (authored by amckinley).Jul 5 2019, 9:25 PM

amckinley added a task: T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()".

amckinley added an edge: D20642: Fix paging fatal with flagged objects.

Harbormaster completed building B23113: rP3c4322252513: Fix paging fatal with flagged objects.Jul 5 2019, 9:26 PM

Changes (1)

Path

Size

src/

applications/

flag/

query/

PhabricatorFlagQuery.php

rP3c4322252513

View Options

src/applications/flag/query/PhabricatorFlagQuery.php