Paths

Table of Contentst

Differential D20514

Allow `setCustomSeverityRules` to be overridden in subclasses
ClosedPublic
Actions

Authored by joshuaspence on May 13 2019, 4:18 AM.

Tags

None

Referenced Files

	F13247692: D20514.diff
	Thu, May 23, 9:42 PM

	F13242893: D20514.diff
	Thu, May 23, 3:11 AM

	F13236849: D20514.diff
	Tue, May 21, 11:11 AM

	F13221239: D20514.diff
	Sun, May 19, 2:23 AM

	F13203647: D20514.diff
	Tue, May 14, 11:58 PM

	F13186128: D20514.diff
	Sat, May 11, 3:26 AM

	F13184360: D20514.id48915.diff
	Fri, May 10, 6:10 PM

	Unknown Object (File)
	Tue, May 7, 6:13 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

I am writing a proxy linter that can be used to wrap any ArcanistExternalLinter and execute all commands within a Docker container (see [[https://github.com/freelancer/flarc/blob/master/src/lint/linter/ArcanistDockerContainerLinterProxy.php |ArcanistDockerContainerLinterProxy]] from [[https://github.com/freelancer/flarc | flarc]]). In order for ArcanistDockerContainerLinterProxy to behave like the ArcanistExternalLinter that is being proxied, final needs to be removed from some methods.

I figured this was reasonable to submit upstream as a similar change (D19630: Allow `willLintPaths` and `didLintPaths` to be overridden) was previously accepted.

Test Plan

N/A

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22788
Build 31263: Run Core Tests
Build 31262: arc lint + arc unit

Event Timeline

joshuaspence created this revision.May 13 2019, 4:18 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 13 2019, 4:18 AM

Harbormaster completed remote builds in B22780: Diff 48907.May 13 2019, 4:19 AM

joshuaspence requested review of this revision.May 13 2019, 4:19 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 13 2019, 4:19 AM

Remove a TODO comment that is no longer relevant

Harbormaster completed remote builds in B22788: Diff 48915.May 13 2019, 11:48 PM

joshuaspence edited the summary of this revision. (Show Details)May 14 2019, 12:30 AM

epriestley accepted this revision.May 14 2019, 2:10 PM

This revision is now accepted and ready to land.May 14 2019, 2:10 PM

Closed by commit rARCfceac878f112: Allow `setCustomSeverityRules` to be overridden in subclasses (authored by joshuaspence). · Explain WhyMay 14 2019, 11:06 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence added an edge: rARCfceac878f112: Allow `setCustomSeverityRules` to be overridden in subclasses.

joshuaspence mentioned this in D20523: Add a hook method that is called after `ArcanistLinter::setEngine`.May 16 2019, 1:57 AM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistLinter.php

5 lines

Diff 48915

src/lint/linter/ArcanistLinter.php

Loading...