Page MenuHomePhabricator

Add a hook method that is called after `ArcanistLinter::setEngine`
Needs ReviewPublic

Authored by joshuaspence on May 16 2019, 1:57 AM.
Tags
None
Referenced Files
F13200810: D20523.id.diff
Tue, May 14, 3:50 AM
F13193057: D20523.id.diff
Sun, May 12, 11:56 AM
F13183769: D20523.id48931.diff
Fri, May 10, 12:17 PM
F13183552: D20523.diff
Fri, May 10, 10:21 AM
Unknown Object (File)
Tue, May 7, 5:43 AM
Unknown Object (File)
Sat, May 4, 8:09 PM
Unknown Object (File)
Fri, May 3, 3:30 AM
Unknown Object (File)
Wed, May 1, 8:26 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Similar to D19730 and D20514, I need a hook that can be used in ArcanistDockerContainerLinterProxy, a third-party linter wrapper. Instead of removing final from ArcanistLinter::setEngine, I figured it was better to create an overridable didSetEngine method, since if subclasses forget to call parent::setEngine() from their own implementation of the setEngine method then bad things might happen?

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
lint5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22905
Build 31424: Run Core Tests
Build 31423: arc lint + arc unit