Page MenuHomePhabricator
Create Task
Maniphest T4591

Allow Harbormaster to source GitHub pull requests as buildables
Closed, WontfixPublic
Actions

Description

It would be great if Harbormaster could use GitHub pull requests as buildables. Probably depends on T1049 being further along (in particular support for non-Herald triggers).

Related Objects
Search...

StatusAssignedTask
 DuplicateNoneT7869 Support CircleCI webhooks for Test results (so that one can run unit tests asynchronously)
 ResolvedepriestleyT9456 Evaluate upstream support for third-party build systems
 ResolvedepriestleyT9123 Build Phabricator in Harbormaster (v2)
 WontfixepriestleyT4591 Allow Harbormaster to source GitHub pull requests as buildables
 ResolvedepriestleyT1049 Implement Harbormaster
 ResolvedepriestleyT2015 Implement Drydock
 Wontfixhach-queT5544 Implement EC2 blueprint for Drydock
 Resolvedhach-queT6074 Determine the best way to prevent the "Lost an allocation race" exception in Drydock
 DuplicateNoneT6076 Provide infrastructure to allow users to perform leases from Arcanist
 ResolvedepriestleyT6111 Give Drydock leases an explicit ownership PHID
 DuplicateNoneT6193 Allow Arcanist to allocate resources through Drydock
Restricted Maniphest Task
 Resolvedhach-queT4111 Use Drydock to allocate build machines for Harbormaster
 ResolvedNoneT4809 Make "arc land" complain if builds are still executing or have failed
 ResolvedNoneT4810 When builds finish, post a transaction to the buildable
 Duplicatehach-queT5493 Allow build plans to be designated "non-critical" which means a failure will not cause the buildable to be failed
 OpenNoneT5515 Support estimation of time remaining and progress indicator based on previous builds
 InvalidNoneT5542 Allow individual Harbormaster targets to be restarted
 Resolvedhach-queT5543 Create the build target dependency tree based on artifacts
 ResolvedepriestleyT5803 Discussion: How will iteration over build steps work?
 OpenNoneT5821 Implement "Run Arc Unit" build step and support showing unit test results inside Harbormaster
 Resolvedhach-queT5831 Run all build commands through PowerShell on Windows
 OpenNoneT5822 Implement garbage collection / automatic archiving for Harbormaster logs
 ResolvedNoneT9494 Standardize GarbageCollector TTLs
 DuplicateNoneT5823 Improve usability and design of Harbormaster
 Resolvedhach-queT5824 Record how long build targets and builds take
Restricted Maniphest Task
 WontfixepriestleyT5857 Change favicon for Harbormaster builds
 WontfixepriestleyT5860 Allow build plans to be cloned in Harbormaster
 WontfixepriestleyT5877 Allow build plans to be "embedded" inside other build plans
 ResolvedNoneT5895 Add an index on harbormaster_buildlog.buildTargetPHID
 ResolvedepriestleyT5932 Archive previous builds (that have been restarted) instead of deleting targets, artifacts and logs
 OpenNoneT5936 Support terminating builds, terminating remote processes and build steps
 OpenNoneT6139 Allow designation of "summary" build logs which are sorted to the top or otherwise promoted
 OpenNoneT9124 Support uploading build log data via the Harbormaster API
 ResolvedepriestleyT5955 Refactor Conduit auth to be stateless, token-based, and support wire encodings
 ResolvedbtrahanT5603 Implement a separate "Can Leave Project" policy

Event Timeline

hach-que created this task.Mar 12 2014, 6:11 AM
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Harbormaster.
hach-que added subscribers: hach-que, epriestley.
hach-que edited this Maniphest Task.Mar 12 2014, 6:11 AM
hach-que updated the task description. (Show Details)Mar 12 2014, 6:12 AM
epriestley triaged this task as Wishlist priority.Apr 24 2014, 1:06 PM

Probably also needs Nuance and Doorkeeper. I don't expect this to happen before, like, 2016.

nchammas added a subscriber: nchammas.Mar 2 2015, 2:01 AM
epriestley closed subtask T1049: Implement Harbormaster as Resolved.Aug 8 2015, 7:14 PM
epriestley closed this task as Wontfix.Aug 8 2015, 7:16 PM
epriestley claimed this task.

I'm just going to close this in favor of T8783. If we build this it would happen via Nuance importing pulls as revisions, not Harbormaster being specifically aware of GitHub pull requests as a buildable, at least in the upstream. You're welcome to do something third-party and implement BuildableInterface on it, which might be a plausible approach, but isn't something I'd want to do in the upstream.

joshuaspence added a subscriber: joshuaspence.Aug 30 2015, 5:46 AM
Phabricator · Built by Phacility