I have not tried to reproduce this in other conditions but here is what happened:
- user1 sent a diff to user2 (in projectA) and user3 (in projectB).
- our herald rule requires that someone in projectA //and// someone in projectB approve this diff.
1) user1 has started editing the diff to modify the description.
2) user3 (in projectA) has approved the diff
3) user1 finishes editing. this removes user3 from the diff because he wasn't in the list of reviewers when user1 started editing.
4) the diff shows a check mark next to projectA but nobody on the reviewer list has accepted the diff.