Page MenuHomePhabricator
Create Task
Maniphest T6767

Removing a reviewer (who has a) accepted a diff and b)satisfies the project reviewer constraint) from a diff does not remove the project reviewer approval status
Closed, InvalidPublic
Actions

Description

I have not tried to reproduce this in other conditions but here is what happened:

  • user1 sent a diff to user2 (in projectA) and user3 (in projectB).
  • our herald rule requires that someone in projectA and someone in projectB approve this diff.
  1. user1 has started editing the diff to modify the description.
  2. user3 (in projectA) has approved the diff
  3. user1 finishes editing. this removes user3 from the diff because he wasn't in the list of reviewers when user1 started editing.
  4. the diff shows a check mark next to projectA but nobody on the reviewer list has accepted the diff.

Event Timeline

kojik1010 created this task.Dec 16 2014, 10:35 PM
kojik1010 raised the priority of this task from to Needs Triage.
kojik1010 updated the task description. (Show Details)
kojik1010 added a subscriber: kojik1010.
chad added a subscriber: chad.Dec 17 2014, 1:21 AM

What is sticky-accept set to in your config?

chad added a comment.Dec 17 2014, 1:22 AM

https://secure.phabricator.com/book/phabricator/article/differential_faq/#why-does-an-accepted-rev

chad added a comment.Dec 17 2014, 4:10 AM

I also don't understand what the bug here is. My guess is because user2 is both in ProjectA and was listed as a reviewer, you felt removing them as a reviewer also revoked them reviewing on behalf of ProjectA? This isn't our expectation and would be very confusing. If user2 shouldn't be reviewing on behalf of ProjectA, they should be removed from the project.

chad closed this task as Invalid.Dec 17 2014, 4:12 AM
chad claimed this task.
Phabricator · Built by Phacility