Change Details

I've got a host `xy.dom.ain` with alias `phab.dom.ain`. I've set `phabricator.base-uri`to `phab.dom.ain`. But mail notifications still have urls which point to `xy.dom.ain`. I've found `phabricator.production-uri` parameter. If set to `phab.dom.ain` the mails contain the correct links. But according the description in the code https://secure.phabricator.com/diffusion/P/browse/master/src/applications/config/option/PhabricatorCoreConfigOptions.php;c986caebb21f7f7119fd45e07a4427ab7f58632b$63 it should default to `phabricator.base-uri`parameter. It seems the getProdcutionURI returns too early for the description to be true: https://secure.phabricator.com/diffusion/P/browse/master/src/infrastructure/env/PhabricatorEnv.php;c986caebb21f7f7119fd45e07a4427ab7f58632b$363

Reproduction steps: * install phabricator on host `vm.dom.ain` * configure phabricator and run `phabricator/bin/config set phabricator.base-uri 'https://phab.dom.ain` * do not set `phabricator.production-uri` * create some action in the gui which sends an notification Expected result: * notification mail has links with `https://phab.dom.ain/` prefixes Actual result: * all links in notification mail have `https://vm.dom.ain` prefix Workaround: * set `phabricator.production-uri` to `https://phab.dom.ain/` to get the expected result seen on: * EL7 (CentOS, RHEL) which includes PHP 5.4 and Apache 2.4 * phabricator version: stable branch from about 2 weeks (will References: * description in the code https://secure.phabricator.com/diffusion/P/browse/master/src/applications/config/option/PhabricatorCoreConfigOptions.php;c986caebb21f7f7119fd45e07a4427ab7f58632b$63 it should default to `phabricator.base-uri`parameter. * It seems the getProdcutionURI returns too early for the description to be true: https://secure.phabricator.com/diffusion/P/browse/master/src/infrastructure/env/PhabricatorEnv.php;c986caebb21f7f7119fd45e07a4427ab7f58632b$363

I've got a host `xy.dom.ain` with alias `phabReproduction steps: * install phabricator on host `vm.dom.ain`. I've set ` * configure phabricator and run `phabricator/bin/config set phabricator.base-uri`to ` 'https://phab.dom.ain`. But mail notifications still have urls * do not set `phabricator.production-uri` * create some action in the gui which point to `xy.dom.ain`.sends an notification I've found `phabricator.producExpected result: * notification-uri` parameter. If set to ` mail has links with `https://phab.dom.ain` the mails contain the correct links. But according the description in the code https://secure.phabricator.com/diffusion/P/browse/master/src/applications/config/option/PhabricatorCoreConfigOptions.php;c986caebb21f7f7119fd45e07a4427ab7f58632b$63 it should default to `phabricator.base-uri`parameter./` prefixes Actual result: * all links in notification mail have `https://vm.dom.ain` prefix Workaround: * set `phabricator.production-uri` to `https://phab.dom.ain/` to get the expected result seen on: * EL7 (CentOS, RHEL) which includes PHP 5.4 and Apache 2.4 * phabricator version: stable branch from about 2 weeks (will References: * description in the code https://secure.phabricator.com/diffusion/P/browse/master/src/applications/config/option/PhabricatorCoreConfigOptions.php;c986caebb21f7f7119fd45e07a4427ab7f58632b$63 it should default to `phabricator.base-uri`parameter. * It seems the getProdcutionURI returns too early for the description to be true: https://secure.phabricator.com/diffusion/P/browse/master/src/infrastructure/env/PhabricatorEnv.php;c986caebb21f7f7119fd45e07a4427ab7f58632b$363