Change Details

The `arc amend` workflow relies on getting the current revision reference using `ArcanistRepositoryAPI::getCurrentWorkingCopyStateRef()` which internally will end up calling `newCurrentCommitSymbol()`, which is not implemented for Mercurial APIs. There isn't an appropriate symbol for Mercurial's current working directory parent commit -- `.` can be used but this does not appear to work properly (indeed any value does not seem to work). This updates `ArcanistMercurialAPI` to override `newCurrentCommitRef()` to avoid needing a current commit symbol and returns a reference by using a manual lookup of the `.` reference. Additionally removed an erroneous early return in `ArcanistAmendWorkflow` which prevents a check against uncommitted changes. Fixes T13665

Mercurial does not have an implementation for querying commit symbol hardpoints, which is what the "arc amend" workflow uses. This provides an implementation for Mercurial as well as updating `ArcanistMercurialAPI` to specify the current working directory symbol as `.`. Additionally removed an erroneous early return in `ArcanistAmendWorkflow` which prevents a check against uncommitted changes. Fixes T13665

The `arc amend` workflow relies on getting the current revision reference using `ArcanistRepositoryAPI::getCurrentWorkingCopyStateRef()` which internally will end up calling `newCurrentCommitSymbol()`, which is not implemented for Mercurial APIs.Mercurial does not have an implementation for querying commit symbol hardpoints, There isn't an appropriate symbol for Mercurial's current working directory parent commit -- `.` can be used but this does not appear to work properly (indeed any value does not seem to work)which is what the "arc amend" workflow uses. This updates `ArcanistMercurialAPI` to override `newCurrentCommitRef()` to avoid needing a current commit symbol and returns a reference by using a manual lookup of the `.` referenceprovides an implementation for Mercurial as well as updating `ArcanistMercurialAPI` to specify the current working directory symbol as `.`. Additionally removed an erroneous early return in `ArcanistAmendWorkflow` which prevents a check against uncommitted changes. Fixes T13665