Let me be clear: I agree with you that there's no ideal implementation here, and it's quite possible to come up with something better/more natural.

That's interesting, and kind of makes sense. You usually comment on the line that you want to discuss.

Short answer: Yes.

@epriestly, it's doing it here:
https://github.com/phacility/libphutil/pull/45

I really suck at online communication, i was referring to Github _enterprise_ in my previous comments. I rarely use github.com, and can't speak to the behavior.

It can not possibly do this

Actually, I'm wondering if it's possible to do what github does. I might be incredibly ignorant here, but since Phabricator abstracts over several version control systems, finding the correct context might not be possible in light of git rebases. This might explain why github can collapse (or not) across fairly drastic changes.

What's different about Phabricator which makes the ability to mark your own comments as done important here but not important on GitHub?

In the general case, it is impossible to bring comments forward on the same line (the line may have been deleted, split into multiple lines, duplicated, completely changed, etc.)

I don't know @epriestley, I found it really confusing to have my comment on a different line entirely. Coupled with the "I can't mark this as done" thing, it made for a confusing experience.

Looking at @chad's comment, I see that we do code reviews vastly differently than you guys do. I don't think I've ever rejected an entire diff in my 3 years here.