Page MenuHomePhabricator

patrickdepinguin (Thomas De Schampheleire)
UserEmail Not Verified


User does not belong to any projects.


  • Clear sailing ahead.


  • Clear sailing ahead.


  • Clear sailing ahead.

User Details

User Since
Feb 18 2015, 6:53 PM (320 w, 6 d)

Recent Activity

Feb 18 2015

patrickdepinguin added a comment to T7316: arc diff vs seperate commits.

The principles you have written down about small commits, one idea = one commit, etc. make perfect sense, it's the same thing we are advocating in our company.
But what I don't understand is how this maps on the issue that Schevalter is highlighting: if you have nicely split up a bigger idea into smaller cohesive ideas, each with a separate commit, how should one send reviews for the whole?
My impression is that you are then launching different 'arc diff's for the different commits, but this is quite some overhead if you have more than 3 commits...

Feb 18 2015, 7:00 PM · Arcanist