Page MenuHomePhabricator

nathanleclaire (Nathan LeClaire)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 1 2018, 2:56 AM (143 w, 6 d)
Availability
Available

Recent Activity

Mar 3 2018

nathanleclaire added a comment to D19161: Add support for Go 1.10 (cached) output.

Ah, thank you. I was _wildly_ confused for a second.

Mar 3 2018, 12:35 AM
nathanleclaire committed rARCdcd7ef66d0e4: Add support for Go 1.10 (cached) output (authored by nathanleclaire).
Add support for Go 1.10 (cached) output
Mar 3 2018, 12:34 AM
nathanleclaire closed D19161: Add support for Go 1.10 (cached) output.
Mar 3 2018, 12:34 AM

Mar 2 2018

nathanleclaire added a comment to D19161: Add support for Go 1.10 (cached) output.

Very confused here -

Mar 2 2018, 7:34 PM
nathanleclaire added a comment to D19161: Add support for Go 1.10 (cached) output.

Thank you for the fast review!

Mar 2 2018, 7:07 PM
nathanleclaire added a comment to D19161: Add support for Go 1.10 (cached) output.

Shrunk the regex down by removing the big glob at the end and removing the spurious \ts like you mentioned. Not sure about whitespace in test files. But the unit tests are still passing with this method.

Mar 2 2018, 6:21 AM
nathanleclaire updated the diff for D19161: Add support for Go 1.10 (cached) output.
  • Shrink regex
Mar 2 2018, 6:20 AM

Mar 1 2018

nathanleclaire added a comment to D19161: Add support for Go 1.10 (cached) output.

FWIW, https://github.com/golang/go/issues/2981 provides JSON output of Go tests now, but that'd require much larger changes to adapt to.

Mar 1 2018, 4:45 AM
nathanleclaire added inline comments to D19161: Add support for Go 1.10 (cached) output.
Mar 1 2018, 4:41 AM
nathanleclaire requested review of D19161: Add support for Go 1.10 (cached) output.
Mar 1 2018, 4:40 AM