Page MenuHomePhabricator

fkf (Florian)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 5 2015, 2:21 PM (301 w, 6 h)
Availability
Available

Recent Activity

Fri, Apr 30

fkf added a comment to T7260: EXCEPTION: (AphrontCharacterSetQueryException) Attempting to construct a query using a non-utf8 string when utf8 is expected.

I don't think HGENCODING applies to the content of changesets, since that would invalidate the changeset hashes and the whole revision graph with it.

Fri, Apr 30, 12:36 PM

Fri, Apr 23

fkf added a comment to T7260: EXCEPTION: (AphrontCharacterSetQueryException) Attempting to construct a query using a non-utf8 string when utf8 is expected.

Is this workaround now the recommended way to deal with this issue / ever going to be merged into the code base?

Fri, Apr 23, 12:41 PM

Aug 6 2015

fkf added a comment to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.

If having the rest of the code run under en_US.UTF-8 is not a problem or even desirable, then that is quite true. It would have implications for eventual localization, though.

Aug 6 2015, 3:22 PM · Diffusion (v3)
fkf added a comment to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.

Sure, parsing locale -a would be a possibility. It's also possible to stay in PHP, for example:

Aug 6 2015, 3:13 PM · Diffusion (v3)
fkf added a comment to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.

Configurability is probably not a good idea -- the comment in the code says that other code parses the output from external tools and expects them to give that output in a fixed manner (particularly in English). This looks like it is hard-coded for a reason.

Aug 6 2015, 2:01 PM · Diffusion (v3)
fkf added a comment to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.

A solution/workaround for this problem appears to be to generate the en_US.UTF-8 locale on the Phabricator host. Restarting Phabricator does not appear to be necessary for the change to take effect, but already-imported repositories will have to be reparsed with bin/repository reparse --all $repository --message --owners.

Aug 6 2015, 12:30 PM · Diffusion (v3)

Aug 5 2015

fkf added a comment to F690786: nonutf8-hg-repo.tar.gz.

Tarball of a Mercurial repository that contains a non-utf8-encoded file name. Can be used to reproduce T7260: EXCEPTION: (AphrontCharacterSetQueryException) Attempting to construct a query using a non-utf8 string when utf8 is expected.

Aug 5 2015, 3:19 PM
fkf added a comment to T7260: EXCEPTION: (AphrontCharacterSetQueryException) Attempting to construct a query using a non-utf8 string when utf8 is expected.

I believe I have the same problem. The cause appears to be a filename that is not fully encodeable in UTF-8 -- in my case, it contains an umlaut. I have uploaded a tarball of a Mercurial repository that can be used to reproduce the problem:

Aug 5 2015, 3:05 PM