Page MenuHomePhabricator

dan-disqus (Dan Fuller)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jan 3 2014, 1:30 AM (536 w, 6 d)
Availability
Available

Recent Activity

Jan 8 2014

dan-disqus added a comment to T4287: Improve warning/error severities in default linters and explanations in help text.

Oh sorry, my mistake on having those values in the .arcconfig. It works fine, there was just an unrelated problem on my end.

Jan 8 2014, 8:01 PM · Arcanist
dan-disqus added a comment to T4287: Improve warning/error severities in default linters and explanations in help text.

Thanks for all the info, I have a much better idea of how/why things work now. I've implemented this using a .arclint with severity.rules and it works perfectly with little tweaking.

Jan 8 2014, 7:45 PM · Arcanist
dan-disqus added a comment to T4287: Improve warning/error severities in default linters and explanations in help text.

The idea is that we have some files that already have a bunch of lint errors. We've then modified the files, and ideally we only want 'new' errors to show up. My reading of --only-new made me think that it'd do exactly that. Essentially, run lint twice - once on a previous revision (for some definition of previous that we might have to specify), and once on the current head (including uncommited files). It'd then compare the two sets of errors, and only print ones that weren't there before.

Jan 8 2014, 2:16 AM · Arcanist

Jan 7 2014

dan-disqus added a comment to T4287: Improve warning/error severities in default linters and explanations in help text.

Just some links to things that might be helpful:
.arcconfig: https://gist.github.com/dan-disqus/bd3de21c6e84bbbc6a62
Our custom arc stuff: https://github.com/disqus/disqus-arcanist/tree/master/src. It doesn't modify ArcanistLintWorkflow, so probably not the cause of the issues.

Jan 7 2014, 10:24 PM · Arcanist

Jan 3 2014

dan-disqus added a comment to T4282: arc lint --only-new 1 not working for ArcanistFlake8Linter.

Sorry, I meant ArcanistPEP8Linter, not PyFlakes.

Jan 3 2014, 2:06 AM