- User Since
- Feb 13 2015, 4:17 PM (297 w, 6 d)
Feb 19 2015
Feb 14 2015
Yeah I understood the audit -> post-merge review ; differential -> pre-merge review, but neither of these applications really serve the use case at hand :) Github's workflow is useful in that case because we get all the contexts : it's possible to comment on the whole request, on the global diff and on each commit, and even better line comments are preserved even when the branch is rebased or commits amended.
Feb 13 2015
Basically, we have a situation where we have a huge branch of unrelated commits that we want to review and merge. We wanted to use phabricator for this, but couldn't figure out a workflow we were happy with with phabricator, and use github for this instead (pull request is at https://github.com/pitivi/gst-devtools/pull/3).