Page MenuHomePhabricator
Differential D21847

Separate Slowvote poll status onto a dedicated object
ClosedPublic
Actions

Authored by epriestley on May 26 2022, 5:46 PM.
Tags
None
Referenced Files
F18419424: D21847.diff
Sat, Aug 30, 2:26 PM
F18410891: D21847.id52069.diff
Sat, Aug 30, 5:27 AM
F18404160: D21847.id52069.diff
Fri, Aug 29, 9:56 PM
F18372847: D21847.diff
Thu, Aug 28, 6:52 AM
F18112232: D21847.id.diff
Tue, Aug 12, 4:14 PM
F18109534: D21847.diff
Mon, Aug 11, 2:22 PM
F18065976: D21847.diff
Mon, Aug 4, 2:18 PM
F18045936: D21847.diff
Sun, Aug 3, 10:06 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rPc1887f0c1d55: Separate Slowvote poll status onto a dedicated object
Summary

Ref T13682. Prepares for use of API-friendly string constants rather than opaque integers.

Test Plan

Created and edited polls, opening and closing them. Grepped for affected methods.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley requested review of this revision.May 26 2022, 5:46 PM
epriestley created this revision.
Harbormaster completed remote builds in B25755: Diff 52069.May 26 2022, 5:46 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 27 2022, 5:15 PM
Closed by commit rPc1887f0c1d55: Separate Slowvote poll status onto a dedicated object (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPc1887f0c1d55: Separate Slowvote poll status onto a dedicated object.

Revision Contents
Changeset List

Diff 52071

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/slowvote/constants/SlowvotePollStatus.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvoteCloseController.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvotePollController.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvoteVoteController.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...
View Options

src/applications/slowvote/view/SlowvoteEmbedView.php

Loading...
Phabricator · Built by Phacility