Differential D21847

Separate Slowvote poll status onto a dedicated object
ClosedPublic
Actions

Authored by epriestley on May 26 2022, 5:46 PM.

Details

Reviewers: None
Maniphest Tasks: T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits: rPc1887f0c1d55: Separate Slowvote poll status onto a dedicated object

Summary

Ref T13682. Prepares for use of API-friendly string constants rather than opaque integers.

Test Plan

Created and edited polls, opening and closing them. Grepped for affected methods.

Diff Detail

Repository

rP Phabricator

Branch

slowvote9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25755
Build 35583: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 26 2022, 5:46 PM

epriestley created this revision.

Harbormaster completed remote builds in B25755: Diff 52069.May 26 2022, 5:46 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 27 2022, 5:15 PM

Closed by commit rPc1887f0c1d55: Separate Slowvote poll status onto a dedicated object (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPc1887f0c1d55: Separate Slowvote poll status onto a dedicated object.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

slowvote/

constants/

SlowvotePollStatus.php

70 lines

controller/

PhabricatorSlowvoteCloseController.php

8 lines

PhabricatorSlowvotePollController.php

18 lines

PhabricatorSlowvoteVoteController.php

2 lines

query/

PhabricatorSlowvoteSearchEngine.php

2 lines

storage/

PhabricatorSlowvotePoll.php

11 lines

view/

SlowvoteEmbedView.php

4 lines

Diff 52069

View Options

src/__phutil_library_map__.php

View Options

src/applications/slowvote/constants/SlowvotePollStatus.php

View Options

src/applications/slowvote/controller/PhabricatorSlowvoteCloseController.php

View Options

src/applications/slowvote/controller/PhabricatorSlowvotePollController.php

View Options

src/applications/slowvote/controller/PhabricatorSlowvoteVoteController.php

View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

View Options

src/applications/slowvote/view/SlowvoteEmbedView.php

Separate Slowvote poll status onto a dedicated objectClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 52069

src/__phutil_library_map__.php

src/applications/slowvote/constants/SlowvotePollStatus.php

src/applications/slowvote/controller/PhabricatorSlowvoteCloseController.php

src/applications/slowvote/controller/PhabricatorSlowvotePollController.php

src/applications/slowvote/controller/PhabricatorSlowvoteVoteController.php

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

src/applications/slowvote/view/SlowvoteEmbedView.php

Separate Slowvote poll status onto a dedicated object
ClosedPublic
Actions

Revision Contents
Changeset List