Page MenuHomePhabricator
Differential D21846

Update Slowvote voting methods to use sensible string constants
ClosedPublic
Actions

Authored by epriestley on May 26 2022, 5:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 8:58 AM
Unknown Object (File)
Sat, Nov 16, 8:35 PM
Unknown Object (File)
Wed, Nov 13, 9:45 PM
Unknown Object (File)
Wed, Nov 13, 9:36 PM
Unknown Object (File)
Oct 13 2024, 6:47 AM
Unknown Object (File)
Oct 9 2024, 2:40 PM
Unknown Object (File)
Oct 1 2024, 8:06 AM
Unknown Object (File)
Sep 23 2024, 10:39 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rP03d3d1889d60: Update Slowvote voting methods to use sensible string constants
Summary

Ref T13682. Use API-friendly string constants instead of opaque integers in Slowvote voting methods.

Test Plan

Created, edited, and voted in polls with various voting methods. Examined database after migrations.

Diff Detail

Repository
rP Phabricator
Branch
slowvote6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25754
Build 35582: arc lint + arc unit

Event Timeline

epriestley created this revision.May 26 2022, 5:24 PM
Owners added a subscriber: Restricted Owners Package.May 26 2022, 5:24 PM
epriestley requested review of this revision.May 26 2022, 5:24 PM
Harbormaster completed remote builds in B25754: Diff 52067.May 26 2022, 5:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 26 2022, 5:27 PM
Closed by commit rP03d3d1889d60: Update Slowvote voting methods to use sensible string constants (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP03d3d1889d60: Update Slowvote voting methods to use sensible string constants.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
5 lines
src/
applications/
slowvote/
constants/
4 lines
controller/
2 lines
storage/
2 lines
view/
6 lines

Diff 52067

View Options

resources/sql/autopatches/20220525.slowvote.06.method-type.sql

Loading...
View Options

resources/sql/autopatches/20220525.slowvote.07.method-value.sql

Loading...
View Options

src/applications/slowvote/constants/SlowvotePollVotingMethod.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...
View Options

src/applications/slowvote/view/SlowvoteEmbedView.php

Loading...
Phabricator · Built by Phacility