Page MenuHomePhabricator
Differential D21838

Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery"
ClosedPublic
Actions

Authored by epriestley on May 24 2022, 5:08 PM.
Tags
None
Referenced Files
F15426816: D21838.largetrue.diff
Sun, Mar 23, 10:56 AM
F15424011: D21838.largetrue.diff
Sat, Mar 22, 7:53 PM
F15421242: D21838.id.diff
Fri, Mar 21, 9:58 PM
F15421241: D21838.largetrue.diff
Fri, Mar 21, 9:58 PM
F15421204: D21838.diff
Fri, Mar 21, 9:43 PM
F15413213: D21838.id.diff
Wed, Mar 19, 5:30 PM
F15391463: D21838.id52051.diff
Sat, Mar 15, 10:02 AM
F15391461: D21838.id52050.diff
Sat, Mar 15, 10:01 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default"
Commits
rP8e703c8c351d: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery"
Summary

Ref T13682. Many subclasses of "CursorPagedPolicyAwareQuery" have the same implementation of "loadPage()", and this is a sensible default behavior.

Test Plan

Examined changes to verify that all removed methods have the same behavior.

Diff Detail

Repository
rP Phabricator
Branch
file1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25745
Build 35573: arc lint + arc unit

Event Timeline

epriestley created this revision.May 24 2022, 5:08 PM
Owners added a subscriber: Restricted Owners Package.May 24 2022, 5:08 PM
epriestley requested review of this revision.May 24 2022, 5:08 PM
Harbormaster completed remote builds in B25745: Diff 52050.May 24 2022, 5:08 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 24 2022, 5:19 PM
Closed by commit rP8e703c8c351d: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP8e703c8c351d: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery".

Large Diff

This large diff affects 112 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
query/
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
auth/
query/
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
badges/
query/
4 lines
4 lines
calendar/
query/
4 lines
4 lines
4 lines
4 lines
conduit/
query/
4 lines
4 lines
countdown/
query/
4 lines
dashboard/
query/
4 lines
4 lines
4 lines
differential/
query/
4 lines
4 lines
4 lines
4 lines
diffusion/
query/
4 lines
doorkeeper/
query/
4 lines
drydock/
query/
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
files/
query/
4 lines
fund/
query/
4 lines
harbormaster/
query/
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
herald/
query/
4 lines
4 lines
4 lines
legalpad/
query/
4 lines
macro/
query/
4 lines
metamta/
query/
4 lines
4 lines
nuance/
query/
4 lines
4 lines
4 lines
4 lines
4 lines
oauthserver/
query/
4 lines
owners/
query/
4 lines
packages/
query/
4 lines
4 lines
4 lines
passphrase/
query/
4 lines
paste/
query/
4 lines
people/
query/
4 lines
4 lines
4 lines
phame/
query/
4 lines
4 lines
pholio/
query/
4 lines
phortune/
query/
4 lines
4 lines
4 lines
4 lines
4 lines
phriction/
query/
4 lines
4 lines
phurl/
query/
4 lines
ponder/
query/
4 lines
4 lines
project/
query/
4 lines
4 lines
4 lines
4 lines
repository/
query/
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
4 lines
search/
query/
4 lines
4 lines
4 lines
slowvote/
query/
4 lines
spaces/
query/
4 lines
tokens/
query/
4 lines
transactions/
query/
4 lines
xhprof/
query/
4 lines
infrastructure/
daemon/
workers/
query/
4 lines
query/
policy/
18 lines

Diff 52050

View Options

src/applications/almanac/query/AlmanacBindingQuery.php

View Options

src/applications/almanac/query/AlmanacDeviceQuery.php

View Options

src/applications/almanac/query/AlmanacInterfaceQuery.php

View Options

src/applications/almanac/query/AlmanacNamespaceQuery.php

View Options

src/applications/almanac/query/AlmanacNetworkQuery.php

View Options

src/applications/almanac/query/AlmanacPropertyQuery.php

View Options

src/applications/almanac/query/AlmanacServiceQuery.php

View Options

src/applications/auth/query/PhabricatorAuthChallengeQuery.php

View Options

src/applications/auth/query/PhabricatorAuthContactNumberQuery.php

View Options

src/applications/auth/query/PhabricatorAuthFactorConfigQuery.php

View Options

src/applications/auth/query/PhabricatorAuthFactorProviderQuery.php

View Options

src/applications/auth/query/PhabricatorAuthMessageQuery.php

View Options

src/applications/auth/query/PhabricatorAuthPasswordQuery.php

View Options

src/applications/auth/query/PhabricatorAuthProviderConfigQuery.php

View Options

src/applications/auth/query/PhabricatorAuthSSHKeyQuery.php

View Options

src/applications/auth/query/PhabricatorAuthSessionQuery.php

View Options

src/applications/auth/query/PhabricatorAuthTemporaryTokenQuery.php

View Options

src/applications/auth/query/PhabricatorExternalAccountIdentifierQuery.php

View Options

src/applications/auth/query/PhabricatorExternalAccountQuery.php

View Options

src/applications/badges/query/PhabricatorBadgesAwardQuery.php

View Options

src/applications/badges/query/PhabricatorBadgesQuery.php

View Options

src/applications/calendar/query/PhabricatorCalendarExportQuery.php

View Options

src/applications/calendar/query/PhabricatorCalendarExternalInviteeQuery.php

View Options

src/applications/calendar/query/PhabricatorCalendarImportLogQuery.php

View Options

src/applications/calendar/query/PhabricatorCalendarImportQuery.php

View Options

src/applications/conduit/query/PhabricatorConduitLogQuery.php

View Options

src/applications/conduit/query/PhabricatorConduitTokenQuery.php

View Options

src/applications/countdown/query/PhabricatorCountdownQuery.php

View Options

src/applications/dashboard/query/PhabricatorDashboardPanelQuery.php

View Options

src/applications/dashboard/query/PhabricatorDashboardPortalQuery.php

View Options

src/applications/dashboard/query/PhabricatorDashboardQuery.php

View Options

src/applications/differential/query/DifferentialChangesetQuery.php

View Options

src/applications/differential/query/DifferentialDiffQuery.php

View Options

src/applications/differential/query/DifferentialHunkQuery.php

View Options

src/applications/differential/query/DifferentialViewStateQuery.php

View Options

src/applications/diffusion/query/DiffusionCommitHintQuery.php

View Options

src/applications/doorkeeper/query/DoorkeeperExternalObjectQuery.php

View Options

src/applications/drydock/query/DrydockAuthorizationQuery.php

View Options

src/applications/drydock/query/DrydockBlueprintQuery.php

View Options

src/applications/drydock/query/DrydockCommandQuery.php

View Options

src/applications/drydock/query/DrydockLeaseQuery.php

View Options

src/applications/drydock/query/DrydockLogQuery.php

View Options

src/applications/drydock/query/DrydockRepositoryOperationQuery.php

View Options

src/applications/drydock/query/DrydockResourceQuery.php

View Options

src/applications/files/query/PhabricatorFileAttachmentQuery.php

View Options

src/applications/fund/query/FundInitiativeQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildArtifactQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildLogQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildMessageQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildStepQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildTargetQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildUnitMessageQuery.php

View Options

src/applications/harbormaster/query/HarbormasterBuildableQuery.php

View Options

src/applications/herald/query/HeraldRuleQuery.php

View Options

src/applications/herald/query/HeraldWebhookQuery.php

View Options

src/applications/herald/query/HeraldWebhookRequestQuery.php

View Options

src/applications/legalpad/query/LegalpadDocumentQuery.php

View Options

src/applications/macro/query/PhabricatorMacroQuery.php

View Options

src/applications/metamta/query/PhabricatorMetaMTAMailPropertiesQuery.php

View Options

src/applications/metamta/query/PhabricatorMetaMTAMailQuery.php

View Options

src/applications/nuance/query/NuanceImportCursorDataQuery.php

View Options

src/applications/nuance/query/NuanceItemCommandQuery.php

View Options

src/applications/nuance/query/NuanceItemQuery.php

View Options

src/applications/nuance/query/NuanceQueueQuery.php

View Options

src/applications/nuance/query/NuanceSourceQuery.php

View Options

src/applications/oauthserver/query/PhabricatorOAuthClientAuthorizationQuery.php

View Options

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

View Options

src/applications/packages/query/PhabricatorPackagesPackageQuery.php

View Options

src/applications/packages/query/PhabricatorPackagesPublisherQuery.php

View Options

src/applications/packages/query/PhabricatorPackagesVersionQuery.php

View Options

src/applications/passphrase/query/PassphraseCredentialQuery.php

View Options

src/applications/paste/query/PhabricatorPasteQuery.php

View Options

src/applications/people/query/PhabricatorPeopleLogQuery.php

View Options

src/applications/people/query/PhabricatorPeopleQuery.php

View Options

src/applications/people/query/PhabricatorPeopleUserEmailQuery.php

View Options

src/applications/phame/query/PhameBlogQuery.php

View Options

src/applications/phame/query/PhamePostQuery.php

View Options

src/applications/pholio/query/PholioImageQuery.php

View Options

src/applications/phortune/query/PhortuneAccountEmailQuery.php

View Options

src/applications/phortune/query/PhortuneAccountQuery.php

View Options

src/applications/phortune/query/PhortuneMerchantQuery.php

View Options

src/applications/phortune/query/PhortunePaymentMethodQuery.php

View Options

src/applications/phortune/query/PhortuneSubscriptionQuery.php

View Options

src/applications/phriction/query/PhrictionContentQuery.php

View Options

src/applications/phriction/query/PhrictionDocumentQuery.php

View Options

src/applications/phurl/query/PhabricatorPhurlURLQuery.php

View Options

src/applications/ponder/query/PonderAnswerQuery.php

View Options

src/applications/ponder/query/PonderQuestionQuery.php

View Options

src/applications/project/query/PhabricatorProjectColumnPositionQuery.php

View Options

src/applications/project/query/PhabricatorProjectColumnQuery.php

View Options

src/applications/project/query/PhabricatorProjectQuery.php

View Options

src/applications/project/query/PhabricatorProjectTriggerQuery.php

View Options

src/applications/repository/query/PhabricatorRepositoryGitLFSRefQuery.php

View Options

src/applications/repository/query/PhabricatorRepositoryIdentityQuery.php

View Options

src/applications/repository/query/PhabricatorRepositoryPullEventQuery.php

View Options

src/applications/repository/query/PhabricatorRepositoryPushEventQuery.php

View Options

src/applications/repository/query/PhabricatorRepositoryPushLogQuery.php

View Options

src/applications/repository/query/PhabricatorRepositoryRefCursorQuery.php

View Options

src/applications/repository/query/PhabricatorRepositorySyncEventQuery.php

View Options

src/applications/repository/query/PhabricatorRepositoryURIQuery.php

View Options

src/applications/search/query/PhabricatorNamedQueryConfigQuery.php

View Options

src/applications/search/query/PhabricatorNamedQueryQuery.php

View Options

src/applications/search/query/PhabricatorProfileMenuItemConfigurationQuery.php

View Options

src/applications/slowvote/query/PhabricatorSlowvoteQuery.php

View Options

src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php

View Options

src/applications/tokens/query/PhabricatorTokenGivenQuery.php

View Options

src/applications/transactions/query/PhabricatorApplicationTransactionCommentQuery.php

View Options

src/applications/xhprof/query/PhabricatorXHProfSampleQuery.php

View Options

src/infrastructure/daemon/workers/query/PhabricatorWorkerBulkJobQuery.php

View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Phabricator · Built by Phacility