Page MenuHomePhabricator
Differential D21823

Remove file attachment edge types, including API access
ClosedPublic
Actions

Authored by epriestley on May 12 2022, 10:40 PM.
Tags
None
Referenced Files
F13107250: D21823.diff
Sat, Apr 27, 10:21 PM
Unknown Object (File)
Thu, Apr 25, 7:33 AM
Unknown Object (File)
Wed, Apr 24, 10:03 AM
Unknown Object (File)
Sat, Apr 20, 5:58 PM
Unknown Object (File)
Sat, Apr 20, 4:12 PM
Unknown Object (File)
Fri, Apr 19, 8:10 AM
Unknown Object (File)
Fri, Apr 19, 4:46 AM
Unknown Object (File)
Mon, Apr 15, 10:02 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
Restricted Maniphest Task
Commits
rPfee8297121f0: Remove file attachment edge types, including API access
Summary

Ref T13603. This removes the file attachment edge types, which no longer have readers or writers.

It does not delete the underlying data.

This indirectly removes API access to this edge. As far as I know, this was only used by one customer (see D21480) who has migrated away from Phabricator.

Test Plan

Grepped for edge constants.

Diff Detail

Repository
rP Phabricator
Branch
file10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25722
Build 35550: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 12 2022, 10:40 PM
epriestley created this revision.
Harbormaster completed remote builds in B25722: Diff 52003.May 12 2022, 10:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM
Closed by commit rPfee8297121f0: Remove file attachment edge types, including API access (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPfee8297121f0: Remove file attachment edge types, including API access.

Revision Contents
Changeset List

Diff 52003

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/edge/PhabricatorFileHasObjectEdgeType.php

Loading...
View Options

src/applications/transactions/edges/PhabricatorObjectHasFileEdgeType.php

Loading...
Phabricator · Built by Phacility