Adjust paste content transaction to support earlier file PHID extraction
ClosedPublic
Actions

Authored by epriestley on May 12 2022, 9:43 PM.

Tags

None

Referenced Files

	F13276003: D21817.diff
	Fri, May 31, 5:26 AM

	F13270346: D21817.id52025.diff
	Wed, May 29, 9:32 AM

	F13270345: D21817.id51997.diff
	Wed, May 29, 9:32 AM

	F13270343: D21817.id.diff
	Wed, May 29, 9:32 AM

	F13262509: D21817.diff
	Mon, May 27, 2:12 AM

	F13250758: D21817.diff
	Fri, May 24, 5:10 PM

	F13216985: D21817.id52025.diff
	Sat, May 18, 3:20 AM

	F13198297: D21817.diff
	Mon, May 13, 5:39 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: Restricted Maniphest Task
Commits: rP4a2d961e7632: Adjust paste content transaction to support earlier file PHID extraction

Summary

Ref T13603. New transactional file attachment extracts PHIDs earlier than the older mechanism did. Allow either pathway to save content and extract a PHID.

Test Plan

Created and modified a paste.
Confirmed both pathways do old and new storage writes.

Diff Detail

Repository

rP Phabricator

Branch

file5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25716
Build 35544: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 12 2022, 9:43 PM

epriestley created this revision.

Harbormaster completed remote builds in B25716: Diff 51997.May 12 2022, 9:43 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM

Closed by commit rP4a2d961e7632: Adjust paste content transaction to support earlier file PHID extraction (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP4a2d961e7632: Adjust paste content transaction to support earlier file PHID extraction.

Revision Contents
Changeset List

Path

Size

src/

applications/

paste/

xaction/

PhabricatorPasteContentTransaction.php

17 lines

Diff 51997

View Options

src/applications/paste/xaction/PhabricatorPasteContentTransaction.php

Adjust paste content transaction to support earlier file PHID extractionClosedPublicActions