Paths

Table of Contentst

Differential D21813

Add database storage for a dedicated file attachment table
ClosedPublic
Actions

Authored by epriestley on May 10 2022, 11:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 25, 7:33 AM

	Unknown Object (File)
	Thu, Apr 25, 1:30 AM

	Unknown Object (File)
	Sat, Apr 20, 5:57 PM

	Unknown Object (File)
	Sat, Apr 20, 4:40 PM

	Unknown Object (File)
	Fri, Apr 19, 8:39 AM

	Unknown Object (File)
	Wed, Apr 17, 9:29 PM

	Unknown Object (File)
	Wed, Apr 17, 10:15 AM

	Unknown Object (File)
	Mon, Apr 15, 10:31 PM

Subscribers

Restricted Owners Package

Details

Reviewers: None
Maniphest Tasks: Restricted Maniphest Task
Commits: rPcfa42c5e655c: Add database storage for a dedicated file attachment table

Summary

Ref T13603. Prepare to move this relationship out of edge storage into dedicated storage so it is easier to formalize better in the UI.

Test Plan

Ran bin/storage upgrade.

Diff Detail

Repository

Branch

file2

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 25710
Build 35538: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	63 ms	PhabricatorFileTestCase::testFileIndirectScramble Assertion failed, expected 'true' (at PhabricatorFileTestCase.php:135): Changing attached object view policy should scramble secret. ACTUAL VALUE
	227 ms	PhabricatorCelerityTestCase::testCelerityMaps 3 assertions passed.
	9 ms	PhabricatorConduitTestCase::testConduitMethods 1 assertion passed.
	19 ms	PhabricatorFileTestCase::testFileDirectScramble 2 assertions passed.
	7 ms	PhabricatorFileTestCase::testFileStorageDelete 1 assertion passed.
		View Full Test Results (1 Failed · 16 Passed)

Event Timeline

epriestley created this revision.May 10 2022, 11:24 PM

Owners added a subscriber: Restricted Owners Package.May 10 2022, 11:24 PM

epriestley requested review of this revision.May 10 2022, 11:24 PM

Harbormaster completed remote builds in B25710: Diff 51990.May 10 2022, 11:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 19 2022, 8:21 PM

This revision was landed with ongoing or failed builds.

Closed by commit rPcfa42c5e655c: Add database storage for a dedicated file attachment table (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPcfa42c5e655c: Add database storage for a dedicated file attachment table.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20220510.file.01.attach.sql

9 lines

src/

__phutil_library_map__.php

applications/

files/

storage/

PhabricatorFileAttachment.php

31 lines

Diff 51990

resources/sql/autopatches/20220510.file.01.attach.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/files/storage/PhabricatorFileAttachment.php

Loading...