Allow "bin/drydock lease ..." to select particular blueprints with "--blueprint"
ClosedPublic
Actions

Authored by epriestley on May 3 2022, 10:03 PM.

Details

Reviewers: None
Maniphest Tasks: T13676: Drydock may reclaim recently-used resources
Commits: rPdfdbe7a6be04: Allow "bin/drydock lease ..." to select particular blueprints with "--blueprint"

Summary

Ref T13676. See discussion in that task.

Test Plan

Tried nonsense blueprint identifiers, duplicate identifiers, incompatible identifiers, and valid identifiers. Got apparently sensible behavior in all cases.

Diff Detail

Repository

rP Phabricator

Branch

drydock6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25697
Build 35525: arc lint + arc unit

Event Timeline

epriestley created this revision.May 3 2022, 10:03 PM

Owners added a subscriber: Restricted Owners Package.May 3 2022, 10:03 PM

epriestley requested review of this revision.May 3 2022, 10:03 PM

Harbormaster completed remote builds in B25697: Diff 51961.May 3 2022, 10:03 PM

epriestley mentioned this in T13676: Drydock may reclaim recently-used resources.May 3 2022, 10:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 3 2022, 10:57 PM

Closed by commit rPdfdbe7a6be04: Allow "bin/drydock lease ..." to select particular blueprints with "--blueprint" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPdfdbe7a6be04: Allow "bin/drydock lease ..." to select particular blueprints with "--blueprint".

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

management/

DrydockManagementLeaseWorkflow.php

80 lines

query/

DrydockBlueprintQuery.php

97 lines

Diff 51961

View Options

src/applications/drydock/management/DrydockManagementLeaseWorkflow.php