Page MenuHomePhabricator
Differential D21795

Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock" pathways
ClosedPublic
Actions

Authored by epriestley on May 3 2022, 6:10 PM.
Tags
None
Referenced Files
F15160362: D21795.diff
Tue, Feb 18, 4:07 AM
Unknown Object (File)
Sun, Feb 16, 8:40 PM
Unknown Object (File)
Sun, Feb 16, 8:37 PM
Unknown Object (File)
Thu, Feb 13, 8:13 PM
Unknown Object (File)
Wed, Feb 12, 6:43 AM
Unknown Object (File)
Sun, Feb 9, 5:22 PM
Unknown Object (File)
Fri, Feb 7, 7:56 AM
Unknown Object (File)
Thu, Feb 6, 3:55 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13588: PHP 8 Compatibility
T13676: Drydock may reclaim recently-used resources
Commits
rP00a20d3cdc54: Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock"…
Summary

Ref T13676. Ref T13588. Fix some issues that prevent "bin/phd" and "bin/drydock" from executing under PHP 8.1, broadly because null is being passed to strlen().

Test Plan

Ran bin/phd debug task and bin/drydock ... under PHP 8.1.

Diff Detail

Repository
rP Phabricator
Branch
drydock1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25689
Build 35517: arc lint + arc unit

Event Timeline

epriestley created this revision.May 3 2022, 6:10 PM
Owners added a subscriber: Restricted Owners Package.May 3 2022, 6:10 PM
epriestley requested review of this revision.May 3 2022, 6:10 PM
Harbormaster completed remote builds in B25689: Diff 51951.May 3 2022, 6:10 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 3 2022, 10:57 PM
Closed by commit rP00a20d3cdc54: Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock"… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP00a20d3cdc54: Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock"….

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
provider/
2 lines
cache/
management/
4 lines
daemon/
event/
7 lines
drydock/
management/
4 lines
policy/
query/
4 lines
repository/
storage/
2 lines
transactions/
storage/
2 lines
infrastructure/
customfield/
standard/
4 lines
query/
policy/
2 lines

Diff 51951

View Options

src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php

Loading...
View Options

src/applications/cache/management/PhabricatorCacheManagementPurgeWorkflow.php

Loading...
View Options

src/applications/daemon/event/PhabricatorDaemonEventListener.php

Loading...
View Options

src/applications/drydock/management/DrydockManagementLeaseWorkflow.php

Loading...
View Options

src/applications/policy/query/PhabricatorPolicyQuery.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility