Differential D21786

Remove product literal strings in "pht()", part 20
ClosedPublic
Actions

Authored by epriestley on Apr 25 2022, 11:12 PM.

Tags

None

Referenced Files

	F15439504: D21786.diff
	Wed, Mar 26, 7:51 AM

	F15433271: D21786.id51924.diff
	Mon, Mar 24, 10:23 PM

	F15432596: D21786.id.diff
	Mon, Mar 24, 6:41 PM

	F15429495: D21786.id51941.diff
	Mon, Mar 24, 2:42 AM

	F15427806: D21786.diff
	Sun, Mar 23, 4:07 PM

	F15421566: D21786.id51923.diff
	Sat, Mar 22, 12:53 AM

	F15409462: D21786.id51941.diff
	Wed, Mar 19, 4:33 AM

	F15407716: D21786.diff
	Tue, Mar 18, 7:08 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13658: How to rebrand Phabricator
Commits: rP07723b46274c: Remove product literal strings in "pht()", part 20

Summary

Test Plan

Static checks only.

Diff Detail

Repository

Branch

product21

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/applications/herald/controller/HeraldWebhookViewController.php:56	XHP134	Use of Product Name Literal

Unit

Test Failures

Build Status

Buildable 25679
Build 35507: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	12 ms	PhabricatorObjectMailReceiverTestCase::testDropInvalidObjectMail EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/maniphest/xaction/ManiphestTaskOwnerTransaction.php(115): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 115) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php(2612): ManiphestTaskOwnerTransaction->validateTransactions(Object(ManiphestTask), Array)
	14 ms	PhabricatorObjectMailReceiverTestCase::testDropUserMismatchMail EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/maniphest/xaction/ManiphestTaskOwnerTransaction.php(115): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 115) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php(2612): ManiphestTaskOwnerTransaction->validateTransactions(Object(ManiphestTask), Array)
	207 ms	PhabricatorCelerityTestCase::testCelerityMaps 3 assertions passed.
	10 ms	PhabricatorConduitTestCase::testConduitMethods 1 assertion passed.
	0 ms	PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed.
		View Full Test Results (2 Failed · 12 Passed)

Event Timeline

epriestley requested review of this revision.Apr 25 2022, 11:12 PM

epriestley created this revision.

Harbormaster completed remote builds in B25679: Diff 51923.Apr 25 2022, 11:12 PM

Fix a PHP 8.1 "strlen(null)" issue.

Harbormaster completed remote builds in B25680: Diff 51924.Apr 25 2022, 11:13 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2022, 11:47 PM

This revision was landed with ongoing or failed builds.

Closed by commit rP07723b46274c: Remove product literal strings in "pht()", part 20 (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP07723b46274c: Remove product literal strings in "pht()", part 20.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

controller/

HeraldRuleController.php

3 lines

HeraldWebhookViewController.php

2 lines

legalpad/

controller/

LegalpadDocumentSignController.php

3 lines

editor/

LegalpadDocumentEditor.php

2 lines

query/

LegalpadDocumentSearchEngine.php

3 lines

meta/

controller/

PhabricatorApplicationEmailCommandsController.php

13 lines

metamta/

applicationpanel/

PhabricatorMetaMTAApplicationEmailPanel.php

2 lines

query/

PhabricatorMetaMTAActor.php

2 lines

receiver/

PhabricatorObjectMailReceiver.php

8 lines

Diff 51923

src/applications/herald/controller/HeraldRuleController.php

Loading...

src/applications/herald/controller/HeraldWebhookViewController.php

Loading...

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Loading...

src/applications/legalpad/editor/LegalpadDocumentEditor.php

Loading...

src/applications/legalpad/query/LegalpadDocumentSearchEngine.php

Loading...

src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php

Loading...

src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php

Loading...

src/applications/metamta/query/PhabricatorMetaMTAActor.php

Loading...

src/applications/metamta/receiver/PhabricatorObjectMailReceiver.php

Loading...