Fix an issue where Herald may fail to extract content from an empty commit
ClosedPublic
Actions

Authored by epriestley on Apr 20 2022, 4:53 PM.

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
T13667: Landing a mercurial revision which has no changes causes errors on the revision page as well as history viewing
Commits: rPde980cc54e8c: Fix an issue where Herald may fail to extract content from an empty commit

Summary

Ref T13667. The Herald "content added" rule (and other similar rules) do not correctly extract content from empty commits.

When we load an empty raw diff, return an empty changed content map.

Ref T13588. Also fix some PHP8.1 null/string stuff

Test Plan

Ran "bin/repository reparse --publish <commit>", with an empty commit hash and a nonempty commit hash.
Reviewed Herald transcripts for general sanity.

Diff Detail

Repository

rP Phabricator

Branch

sub3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25650
Build 35478: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 20 2022, 4:53 PM

Harbormaster completed remote builds in B25646: Diff 51873.Apr 20 2022, 4:53 PM

epriestley requested review of this revision.Apr 20 2022, 4:53 PM

Also fix some PHP 8.1 "strlen(null)" behavior.

Harbormaster completed remote builds in B25648: Diff 51876.Apr 20 2022, 6:13 PM

epriestley mentioned this in T13667: Landing a mercurial revision which has no changes causes errors on the revision page as well as history viewing.Apr 20 2022, 6:31 PM

Fix some more "strlen(null)" behavior.

Harbormaster completed remote builds in B25650: Diff 51878.Apr 20 2022, 6:42 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 20 2022, 8:04 PM

Closed by commit rPde980cc54e8c: Fix an issue where Herald may fail to extract content from an empty commit (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPde980cc54e8c: Fix an issue where Herald may fail to extract content from an empty commit.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

herald/

HeraldCommitAdapter.php

9 lines

query/

pathchange/

DiffusionPathChangeQuery.php

7 lines

request/

DiffusionRequest.php

16 lines

macro/

query/

PhabricatorMacroQuery.php

4 lines

passphrase/

query/

PassphraseCredentialQuery.php

2 lines

repository/

query/

PhabricatorRepositoryQuery.php

2 lines

storage/

PhabricatorRepository.php

22 lines

infrastructure/

markup/

PhabricatorMarkupEngine.php

8 lines

render.php

4 lines

Diff 51878

View Options

src/applications/diffusion/herald/HeraldCommitAdapter.php

View Options

src/applications/diffusion/query/pathchange/DiffusionPathChangeQuery.php

View Options

src/applications/diffusion/request/DiffusionRequest.php

View Options

src/applications/macro/query/PhabricatorMacroQuery.php

View Options

src/applications/passphrase/query/PassphraseCredentialQuery.php

View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

View Options

src/infrastructure/markup/render.php

Fix an issue where Herald may fail to extract content from an empty commitClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51878

src/applications/diffusion/herald/HeraldCommitAdapter.php

src/applications/diffusion/query/pathchange/DiffusionPathChangeQuery.php

src/applications/diffusion/request/DiffusionRequest.php

src/applications/macro/query/PhabricatorMacroQuery.php

src/applications/passphrase/query/PassphraseCredentialQuery.php

src/applications/repository/query/PhabricatorRepositoryQuery.php

src/applications/repository/storage/PhabricatorRepository.php

src/infrastructure/markup/PhabricatorMarkupEngine.php

src/infrastructure/markup/render.php

Fix an issue where Herald may fail to extract content from an empty commit
ClosedPublic
Actions

Revision Contents
Changeset List