Differential D21732

Allow "PhutilAWSException" to identify "EBS: Not Found" errors
ClosedPublic
Actions

Authored by epriestley on Nov 19 2021, 10:27 PM.

Details

Reviewers: None
Maniphest Tasks: T13630: Move Phacility provisioning to Piledriver
Commits: rARC7cbdf378198b: Allow "PhutilAWSException" to identify "EBS: Not Found" errors

Summary

Ref T13630. Piledriver cares about EBS error specifics; expand this class a bit to expose more error information.

Test Plan

Created and destroyed resource piles with Piledriver control code, elsewhere.

Diff Detail

Repository

rARC Arcanist

Branch

aws2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25583
Build 35388: Run Core Tests
Build 35387: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 19 2021, 10:27 PM

Harbormaster completed remote builds in B25583: Diff 51789.Nov 19 2021, 10:28 PM

epriestley requested review of this revision.Nov 19 2021, 10:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2021, 10:55 PM

Closed by commit rARC7cbdf378198b: Allow "PhutilAWSException" to identify "EBS: Not Found" errors (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC7cbdf378198b: Allow "PhutilAWSException" to identify "EBS: Not Found" errors.

Revision Contents
Changeset List

Path

Size

src/

future/

aws/

PhutilAWSException.php

20 lines

PhutilAWSFuture.php

26 lines

Diff 51789

View Options

src/future/aws/PhutilAWSException.php